Closed Bug 1297402 Opened 8 years ago Closed 8 years ago

change public xpt functions to return bool instead of PRBool

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: froydnj, Assigned: n.nethercote)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since we no longer care about binary compat, this change is now feasible.  This change enables removing the prtypes.h include from xpt_arena.h, from which a bunch of other files bootleg PRBool.
I hope you haven't already written a patch for this :)

I had to replace the prtypes.h inclusion with prcpucfg.h because xpt still
relies on the IS_{BIG,LITTLE}_ENDIAN macros. Hopefully that's ok; there are
currently eight other non-NSPR files that #include prcpucfg.h.
Attachment #8784690 - Flags: review?(nfroyd)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8784690 [details] [diff] [review]
Change public xpt functions to return bool instead of PRBool

Review of attachment 8784690 [details] [diff] [review]:
-----------------------------------------------------------------

I did have a patch for this, but no matter!
Attachment #8784690 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7f7fe72ad6db1820caa087bed71388a4fd44591
Bug 1297402 - Change public xpt functions to return bool instead of PRBool. r=froydnj.
> I did have a patch for this, but no matter!

Did you do your review by diffing my patch against yours? :)
https://hg.mozilla.org/mozilla-central/rev/e7f7fe72ad6d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: