Closed Bug 1297429 Opened 4 years ago Closed 3 years ago

Intermittent dom/media/test/test_background_video_suspend.html | Test timed out.

Categories

(Core :: Audio/Video, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kamidphish)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Flags: needinfo?(dglastonbury)
I've been investigating these intermittent failures on Linux and it appears that we are missing events or getting multiple playing events.
Flags: needinfo?(dglastonbury)
When playback stutters, readyState can flip between CURRENT_DATA and FUTURE_DATA. 'playing' events might fire multiple times.
(In reply to JW Wang [:jwwang] from comment #2)
> When playback stutters, readyState can flip between CURRENT_DATA and
> FUTURE_DATA. 'playing' events might fire multiple times.

While that is happening, it turns out that here the suspend wasn't happening because the timer was being cancelled by decoder->NotifyOwnerActivityChanged() clearing the visibility that the mochitest is setting.
Comment on attachment 8784660 [details]
Bug 1297429 - Fix video suspend intermittent failures.

https://reviewboard.mozilla.org/r/74016/#review71920

::: dom/media/MediaDecoder.cpp:511
(Diff revision 1)
>    , mPinnedForSeek(false)
>    , mPausedForPlaybackRateNull(false)
>    , mMinimizePreroll(false)
>    , mMediaTracksConstructed(false)
>    , mFiredMetadataLoaded(false)
> +  , mElementVisible(true)

This should be initialized to be !aOwner->IsHidden().

::: dom/media/MediaDecoder.cpp:1375
(Diff revision 1)
> +}
> +
> +void
> +MediaDecoder::SetForcedHidden(bool aForcedHidden)
> +{
> +    MOZ_ASSERT(NS_IsMainThread());

indentation.
Attachment #8784660 - Flags: review?(jwwang) → review+
Pushed by dglastonbury@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f54395b2ac4
Fix video suspend intermittent failures. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/0f54395b2ac4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee: nobody → dglastonbury
You need to log in before you can comment on or make changes to this bug.