129746 - oncommand fired for <menulist/> incorrectly

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Håkan Waara]

I first encountered this in bug 129714.

Basically, what we have is a label, that's mapped to a menulist:

<label ... control="aControl" accesskey="b"/> 
<menulist id="aControl" oncommand="doSomething();">...</menulist>

doSomething(); will be triggered, when the label's accesskey is fired. Even if
it's just a focus event.

Bug or feature?

Comment 1

[Håkan Waara]

In the case of  bug 129714, we get some weird values, which is how I found this
originally.

Comment 2

[jag (Peter Annema)]

-> me

Shouldn't be too hard to fix, basically there's some code there in
nsEventStateManager that currently checks to see whether the element is a
textbox, and if so it only focuses. Menulists should probably get the same
behaviour.

Aaron?

Comment 3

[jag (Peter Annema)]

http://lxr.mozilla.org/seamonkey/source/content/events/src/nsEventStateManager.cpp#861

Change that so it also just focuses for ::menulist.

Comment 4

[Håkan Waara]

Attachment: Fix

Attaching the fix proposed by jag.  Thanks to Matti for making sure it works.

Comment 5

[Blake Ross]

Comment on attachment 73756 [details] [diff] [review]
Fix

r=blake

Comment 6

[Joe Hewitt (gone)]

Comment on attachment 73756 [details] [diff] [review]
Fix

sr=hewitt

Comment 7

[Joe Hewitt (gone)]

Comment on attachment 73756 [details] [diff] [review]
Fix

sr=hewitt

Comment 8

[Joe Hewitt (gone)]

Comment on attachment 73756 [details] [diff] [review]
Fix

sr=hewitt

Comment 9

[Håkan Waara]

-> me

Comment 10

[jag (Peter Annema)]

Yep, that's exactly what I meant.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 73756 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[Håkan Waara]

fixed.

Comment 13

[shrirang khanzode]

.