Closed
Bug 1297483
Opened 8 years ago
Closed 7 years ago
Centralize what is valid version number and what kind of release it represents (beta, esr, etc.)
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file, 1 obsolete file)
98 bytes,
text/plain
|
Details |
Follow up of bug 1297011 comment 5.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8784084 -
Flags: review?(rail)
Comment 2•8 years ago
|
||
Comment on attachment 8784084 [details] [review]
PR
See my comments in PR #114.
Attachment #8784084 -
Flags: review?(rail) → review-
Assignee | ||
Comment 3•8 years ago
|
||
I agree with that. Creating a python parser for the JS regex is also not very robust. We could create a language-neutral file, from which we generate the JS and the Python regexes. Like Rail said offline, we might hit some features that are only supported in one language, but not the other. Also, this will add complexity in the build pipeline, which seems unneeded at the moment.
Maybe we missed a smarter way to do it.
Sylvestre, do you think we require the regex to be at one single place, knowing the cost of complexity?
Flags: needinfo?(sledru)
Comment 4•8 years ago
|
||
ok, let's it this way for a big warning on top of the regexp.
However, we could still create a dedicated library for this.
Flags: needinfo?(sledru)
Updated•8 years ago
|
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Attachment #8784084 -
Attachment is obsolete: true
Assignee | ||
Comment 5•8 years ago
|
||
I'm not actively working on this issue, and we need another way to solve the issue. Let's make this bug open for others.
Assignee: jlorenzo → nobody
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Comment 6•7 years ago
|
||
I just started to work on a python library that tells whether a version number is valid or not and what kind of version it is (beta, esr, etc.). I need it for bug 1470942.
Let's not deal with the JS/Python bridge in this bug, but let's track the creation of a centralized library.
Assignee: nobody → jlorenzo
Status: RESOLVED → REOPENED
Component: Applications: Shipit (backend) → General
QA Contact: rail → catlee
Resolution: INCOMPLETE → ---
Summary: Centralize regex of a valid version number → Centralize what is valid version number and what kind of release it represents (beta, esr, etc.)
Assignee | ||
Comment 7•7 years ago
|
||
I ported the logic used in ship-it https://github.com/mozilla-releng/ship-it/blob/9c6ecbac45fe7f5e8f1a4f5bbde43361954a3847/kickoff/static/model/release.js into its own python lib. The lib has 100% test coverage.
Assignee | ||
Comment 8•7 years ago
|
||
The package has been deployed[1] with the first piece of feedback received[2]. Let's close this bug and track issues with the library at: https://github.com/mozilla-releng/mozilla-version/issues/
[1] https://pypi.org/project/mozilla-version/0.1.2/
[2] https://github.com/mozilla-releng/mozilla-version/issues/2
Status: REOPENED → RESOLVED
Closed: 8 years ago → 7 years ago
Resolution: --- → FIXED
Comment 9•7 years ago
|
||
Bravo!
You need to log in
before you can comment on or make changes to this bug.
Description
•