1297498 - Enable source maps in Console by default on Nightly

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Jaideep Bhoosreddy [:jbhoosreddy]]

Currently, source maps in console has to be enabled manually in about:config because it is still in its experimental state. This bug is to enable this feature by default only on Nightly, and so we can test it out before we can enable it in for everyone.

Comment 1

[Jaideep Bhoosreddy [:jbhoosreddy]]

Attachment: 1297498.patch

As per Brian's comment in [1], this patch enables source maps in web console in Nightly builds.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1289570#c4

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8784107 [details] [diff] [review]
1297498.patch

Review of attachment 8784107 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  Please do a try push before marking for checkin

Comment 3

[Jaideep Bhoosreddy [:jbhoosreddy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24bb64e1c0cd

Comment 4

[Jaideep Bhoosreddy [:jbhoosreddy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=636e43756bb9

Comment 5

[Jaideep Bhoosreddy [:jbhoosreddy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c95bb124a08d

Comment 6

[Jaideep Bhoosreddy [:jbhoosreddy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecc7b2d8766e

Comment 7

[Jaideep Bhoosreddy [:jbhoosreddy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae637f2078eb

Comment 8

[Jaideep Bhoosreddy [:jbhoosreddy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=399ece45b046

Comment 9

[Brian Grinstead [:bgrins]]

As per discussion, let's focus on getting sourcemaps working on the client before turning them on in console (first for new debugger frontend, then move that up to toolbox, then have webconsole use the toolbox).

Maybe that will shake out the test failure we've been seeing also

Comment 10

[Patrick Brosset <:pbro>]

The client-side source map service has now landed. So we can now make use of it in the console.
toolbox.sourceMapService will get you the service.

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Patrick Brosset <:pbro> from comment #10)
> The client-side source map service has now landed. So we can now make use of
> it in the console.
> toolbox.sourceMapService will get you the service.
Yes, definitely agree.
I am updating the blocking field.

Honza

Comment 12

[Tom Tromey :tromey]

This was fixed by bug 1359144, which changed the console to use client-side source maps.