Closed Bug 1297518 Opened 5 years ago Closed 5 years ago

Intermittent toolkit/components/url-classifier/tests/mochitest/test_bug1254766.html | Should not import bad css - didn't expect "hidden", but got it

Categories

(Toolkit :: General, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dimi)

Details

(Keywords: intermittent-failure, Whiteboard: #sbv4-m1)

Attachments

(1 file)

Flags: needinfo?(dlee)
Working on this bug right now
Assignee: nobody → dlee
Status: NEW → ASSIGNED
The root cause is that in certain platform(Android in this case), http request, response may take longer than expect.

In test_gethash.html and test_bug1254766.html we will use |gethash.sjs| to simulate gethash server, but if the response takes long than the timeout threshold[1], then the testcase will fail.

I think we don't have to care about gethash timeout for testcases, so the solution here is just increase the timeout value.

[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierHashCompleter.js#358
Flags: needinfo?(dlee)
Attachment #8787131 - Flags: review?(hchang)
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

Brilliant finding! Thanks!
Attachment #8787131 - Flags: review?(hchang) → feedback+
Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

https://reviewboard.mozilla.org/r/75990/#review74874
Attachment #8787131 - Flags: review?(gpascutto) → review+
Whiteboard: #sbv4-m1
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/223b9a23f373
Increase gethash timeout for testcases. r=gcp
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/223b9a23f373
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.