Intermittent toolkit/components/url-classifier/tests/mochitest/test_bug1254766.html | Should not import bad css - didn't expect "hidden", but got it

RESOLVED FIXED in Firefox 51

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: intermittent-bug-filer, Assigned: dimi)

Tracking

({intermittent-failure})

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: #sbv4-m1)

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Flags: needinfo?(dlee)
(Assignee)

Comment 2

3 years ago
Working on this bug right now
Assignee: nobody → dlee
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
The root cause is that in certain platform(Android in this case), http request, response may take longer than expect.

In test_gethash.html and test_bug1254766.html we will use |gethash.sjs| to simulate gethash server, but if the response takes long than the timeout threshold[1], then the testcase will fail.

I think we don't have to care about gethash timeout for testcases, so the solution here is just increase the timeout value.

[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierHashCompleter.js#358
Flags: needinfo?(dlee)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 years ago
Attachment #8787131 - Flags: review?(hchang)

Comment 5

3 years ago
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

Brilliant finding! Thanks!
Attachment #8787131 - Flags: review?(hchang) → feedback+
Comment hidden (mozreview-request)
Comment hidden (Intermittent Failures Robot)

Comment 9

3 years ago
mozreview-review
Comment on attachment 8787131 [details]
Bug 1297518 - Increase gethash timeout for testcases.

https://reviewboard.mozilla.org/r/75990/#review74874
Attachment #8787131 - Flags: review?(gpascutto) → review+
Whiteboard: #sbv4-m1
Comment hidden (mozreview-request)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 12

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/223b9a23f373
Increase gethash timeout for testcases. r=gcp
Keywords: checkin-needed

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/223b9a23f373
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.