improve handling of massive diffs (avoid slow script dialog)

NEW
Unassigned

Status

MozReview
General
2 years ago
a year ago

People

(Reporter: tnikkel, Unassigned)

Tracking

(Blocks: 1 bug)

Details

(Reporter)

Description

2 years ago
Load https://reviewboard.mozilla.org/r/64314/diff/2#index_header and you get a slow script warning. Reproduces in fresh profile and in nightly and 45. It never seems to recover.
what's causing this is the size of the patch: 111,141 insertions; 8,163 deletions.

we should catch when a diff might be too large to review (i suspect experimentation will be required to find the right value), and instead show a link to the raw diff (https://reviewboard-hg.mozilla.org/gecko/raw-rev/85572a505fb2 in this case).
Summary: slow script dialog → improve handling of massive diffs (avoid slow script dialog)

Comment 2

2 years ago
Almost certainly a dupe of other dependencies of this blocker, but we'll sort that out later.
Blocks: 1288133
You need to log in before you can comment on or make changes to this bug.