129756 - PK11_SetObjectNickname is broken

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Jamie Nicolson]

1) It incorrectly sets len = strlen(nickname)-1. It should just set
len=strlen(nickname).

2) It doesn't acquire a read-write session on the slot. So the operation fails
when it tries to set the label on a token object.

I'll attach a patch that addresses these two problems.

Comment 1

[Jamie Nicolson]

Attachment: proposed patch

This patch does two things.

1) Sets the length of the attribute correctly to be the strlen() of the
nickname.

2) Obtains a read-write session so it can write to token objects.

Comment 2

[Jamie Nicolson]

Adding wtc to the CC list.

Bob, can you please review the patch?

Comment 3

[Wan-Teh Chang]

Comment on attachment 73294 [details] [diff] [review]
proposed patch

The PK11_EnterSlotMonitor and PK11_ExitSlotMonitor calls in
this patch are not matched.  I guess the PK11_EnterSlotMonitor
call also needs to be deleted?

Comment 4

[Jamie Nicolson]

Attachment: remove the EnterSlotMonitor call

wtc is right. PK11_GetRWSession should replace PK11_EnterSlotMonitor.

Comment 5

[Robert Relyea]

Comment on attachment 73322 [details] [diff] [review]
remove the EnterSlotMonitor call

This patch still has the extra PK11_ExitSlotMonitor in the error path (which is
really a bug in the original code). 

Other than that it is fine.

Comment 6

[Jamie Nicolson]

Attachment: proposed patch

Doh!

This time, for sure.

Comment 7

[Robert Relyea]

Comment on attachment 73607 [details] [diff] [review]
proposed patch

ok r=relyea

Comment 8

[Jamie Nicolson]

Checked in to trunk for NSS 3.4.

/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.33; previous revision: 1.32

Comment 9

[Wan-Teh Chang]

Set target milestone to NSS 3.4.