Closed
Bug 1297578
Opened 8 years ago
Closed 8 years ago
Remove ShadowLayersManager
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
Details
Attachments
(2 files)
|
17.00 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
|
19.73 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This is a really confusing name, we should just put the functionality on a base class of the CompositorBridgeParent implementations instead.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8784209 -
Flags: review?(nical.bugzilla)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8784210 -
Flags: review?(dvander)
|
|
Assignee | |
Comment 3•8 years ago
|
||
As a followup it would be nice to rename the concrete class 'WindowCompositorBridgeParent' and 'ContentCompositorBridgeParent' (CrossProcess is no longer meaningful with GPU process) and then we could drop 'Base' from the abstract class.
|
||
Updated•8 years ago
|
Attachment #8784209 -
Flags: review?(nical.bugzilla) → review+
Attachment #8784210 -
Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/68ab74be3039 Part 1: Create a base CompositorBridgeParent class and avoid implementing things twice. r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/e6ac4dbe34be Part 2: Merge ShadowLayersManager into the CBP base. r=dvander
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/68ab74be3039 https://hg.mozilla.org/mozilla-central/rev/e6ac4dbe34be
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•