1297589 - Move the Win7 VM rows up next to the Win7 rows

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Phil Ringnalda (:philor)]

We display a row for Win7 opt, a row for Win7 debug, then after two rows for Win8 and seven rows of Android we have the Win7 VM opt and Win7 VM debug rows. The VM rows should instead be immediately after the non-VM rows.

Comment 1

[Phil Ringnalda (:philor)]

Where by "after" I mean

Windows 7 opt
Windows 7 VM opt
Windows 7 pgo
Windows 7 VM pgo
Windows 7 debug
Windows 7 VM debug

- for some reason, Win7 VM is also the only platform which lists debug before opt.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Link to PR 1802

Hmm, this didn't get autocreated. Guess pulse is still screwy.

Anyway, this patch gets the order to be:
Windows 7 opt
Windows 7 pgo
Windows 7 debug
Windows 7 VM opt
Windows 7 VM pgo
Windows 7 VM debug


Not sure we can get comment 1's requested ordering without doing a more complicated patch.

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8784249 [details] [review]
Link to PR 1802

As you say, not sure if this is acceptable to call the bug fixed or not.  That's up to Philor.  But at least this is an improvement.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bb8e6fc15e2dee56f7f6ae820ef91eeebe4cde7d
Bug 1297589 - Add Windows 7 VM to thPlatformOrder so it can be grouped (#1802) r=camd

Comment 5

[Phil Ringnalda (:philor)]

No, it must be exactly as I said, EXACTLY!