Misleading indentation in graphite2/src/Face.cpp

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nical, Assigned: jfkthame)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Reporter

Updated

3 years ago
Blocks: 1297639
Assignee

Comment 1

3 years ago
Martin, over to you - looks like this is still the same in the latest upstream rev.
Flags: needinfo?(martin_hosken)

Comment 2

3 years ago
Fixed upstream in: 8d6515dec59d527e9086103dcfd40b5ac19a2bd0
Assignee

Comment 3

3 years ago
Thanks, Tim.

We should go ahead and take this; no need to wait for a new upstream release that incorporates it.
Flags: needinfo?(martin_hosken)
Assignee

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Reporter

Comment 5

3 years ago
Comment on attachment 8791620 [details] [diff] [review]
Cherry-pick upstream fix for misleading-indent/missing-brace bug

Review of attachment 8791620 [details] [diff] [review]:
-----------------------------------------------------------------

great, thanks!
Attachment #8791620 - Flags: review?(nical.bugzilla) → review+
Assignee

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/20fd10d6ef21ef4aa43b88006adf4f4f61d55249
Bug 1297644 - Cherry-pick upstream fix for misleading-indent/missing-brace bug. r=nical

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/20fd10d6ef21
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.