Closed
Bug 1297644
Opened 8 years ago
Closed 8 years ago
Misleading indentation in graphite2/src/Face.cpp
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: nical, Assigned: jfkthame)
References
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
Here: http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/gfx/graphite2/src/Face.cpp#333
The if block needs to be braced.
|
Assignee | |
Comment 1•8 years ago
|
||
Martin, over to you - looks like this is still the same in the latest upstream rev.
Flags: needinfo?(martin_hosken)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks, Tim.
We should go ahead and take this; no need to wait for a new upstream release that incorporates it.
Flags: needinfo?(martin_hosken)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8791620 -
Flags: review?(nical.bugzilla)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8791620 [details] [diff] [review]
Cherry-pick upstream fix for misleading-indent/missing-brace bug
Review of attachment 8791620 [details] [diff] [review]:
-----------------------------------------------------------------
great, thanks!
Attachment #8791620 -
Flags: review?(nical.bugzilla) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/20fd10d6ef21ef4aa43b88006adf4f4f61d55249
Bug 1297644 - Cherry-pick upstream fix for misleading-indent/missing-brace bug. r=nical
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•