Closed
Bug 1297659
Opened 8 years ago
Closed 8 years ago
Misleading indentation in nsHTMLEntities.cpp
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: nical, Assigned: nical)
References
Details
Attachments
(1 file)
|
1.56 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
Here: http://searchfox.org/mozilla-central/diff/16905de36126927389e052c33bc7c4681b1b0038/parser/htmlparser/src/nsHTMLEntities.cpp#181 This causes ggc6 to warn about misleading indentation. A lot of the other occurrences of this warning are genuine bugs, so let's make sure we can build gecko without triggering the warning.
Attachment #8784310 -
Flags: review?(hsivonen)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8784310 [details] [diff] [review] Fix the indentation. We should really remove the file, but r+ for now.
Attachment #8784310 -
Flags: review?(hsivonen) → review+
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc5a4525f6c2 Indentation fix in nsHTMLEntities.cpp. r=hsivonen
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bc5a4525f6c2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•