Closed
Bug 1297720
Opened 8 years ago
Closed 8 years ago
Streamline ToNumberSlow
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file, 1 obsolete file)
|
2.66 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
This branch [1] is dead because ToPrimitive cannot return an object. And the goto statement can be removed by moving the isNumber [3] condition after calling ToPrimitive. [1] http://hg.mozilla.org/mozilla-central/file/01748a2b1a46/js/src/jsnum.cpp#l1619 [2] http://hg.mozilla.org/mozilla-central/file/01748a2b1a46/js/src/jsnum.cpp#l1580 [3] http://hg.mozilla.org/mozilla-central/file/01748a2b1a46/js/src/jsnum.cpp#l1582
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8784389 -
Flags: review?(jorendorff)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Updated patch to apply on inbound and switching reviewer.
Attachment #8784389 -
Attachment is obsolete: true
Attachment #8784389 -
Flags: review?(jorendorff)
Attachment #8806427 -
Flags: review?(till)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8806427 [details] [diff] [review] bug1297720.patch Review of attachment 8806427 [details] [diff] [review]: ----------------------------------------------------------------- Much nicer, thank you.
Attachment #8806427 -
Flags: review?(till) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/382e04e39c82 Streamline ToNumberSlow's code so it matches ToStringSlow. r=till
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/382e04e39c82
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•