1297775 - Combine thPlatformNameMap and thPlatformOrder into a single mapping so they always stay in sync

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bug 1297589 was caused by win7vm not being listed in thPlatformOrder, causing it to be grouped into "other" with a priority of 99 [1]. It was listed in thPlatformNameMap, though, so it got its prettified name applied correctly.

I'd argue that any platform listed in the name mapping should also be listed in the order mapping, so we don't have to keep remembering to add platforms to the ordering. 

Or maybe we can just use a single mapping that maps to both the pretty name and the order priority...

Thoughts?



[1] I think this it true. Maybe it doesn't get grouped as "other" and just ends at the bottom of the list?

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: PR 1808

This PR combines thPlatformNameMap and thPlatformOrder into a single object called thPlatformMap. It adjusts anything that used the now-gone objects to use thPlatformMap.

While making this change, I also updated the platform orders to correct a typo. 
Also, I added a bit more padding to the orders at the start of some of the groups of platforms so future additions don't have to adjust 30-some priorities. 
Also also, I added some newer android platform variants to the mapping so they get grouped and labeled correctly in the UI.

Comment 2

[Ed Morley [:emorley]]

(Untested, so please check all working :-))

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Did testing last night and all seemed good. Could we try this on stage at some point after landing?

Updating summary to reflect reality.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/27cf34278229ba1ae41dcef2f892df5d70e122d6
Bug 1297775 - Combine thPlatformNameMap and thPlatformOrder (#1808) r=emorley