Closed
Bug 1297820
Opened 8 years ago
Closed 8 years ago
Check if we have a nsIWidget before using NS_NATIVE_OPENGL_CONTEXT in CompositorOGL
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: rhunt, Assigned: rhunt)
Details
Attachments
(1 file, 1 obsolete file)
|
1.58 KB,
patch
|
Details | Diff | Splinter Review |
We can't use RealWidget() if we are in the GPU process, and currently it seems like only gonk and a mock widget implement GetNativeData for NS_NATIVE_OPENGL_CONTEXT.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8784539 -
Flags: review?(jgilbert)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8784539 [details] [diff] [review] check-nsIWidget.patch Review of attachment 8784539 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/opengl/CompositorOGL.cpp @@ +143,5 @@ > NS_WARNING("Failed to create CompositorOGL context"); > } > > #ifdef MOZ_WIDGET_GONK > + widget->SetNativeData( We handle widget=nullptr above, but seemingly not here. Leave either a comment or an assert.
Attachment #8784539 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8784539 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e59fbcb1da07 Check if we have a nsIWidget before using NS_NATIVE_OPENGL_CONTEXT. r=jgilbert
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e59fbcb1da07
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•