Closed Bug 1297845 Opened 5 years ago Closed 5 years ago

Initialize the gdk_default_display in GPU process

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

Attachments

(1 file, 1 obsolete file)

We need to have gdk_default_display for GL Layers in the GPU process, and this will also help fix the issue where we open multiple display's when we are running on the GPU process in Bug 1289251.
Attached patch gdk-default-display.patch (obsolete) — Splinter Review
This patch mirrors how the content process initializes gtk (ContentChild::Init), except we only set the default display.
Attachment #8784576 - Flags: review?(andrew)
Comment on attachment 8784576 [details] [diff] [review]
gdk-default-display.patch

Review of attachment 8784576 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUParent.cpp
@@ +102,5 @@
> +  if (!display) {
> +    printf_stderr("Error: cannot open display: %s\n", display_name);
> +    return false;
> +  }
> +  gdk_display_manager_set_default_display(gdk_display_manager_get(),

Do we ever call gdk_init (or equivalents) in the GPU process?

https://developer.gnome.org/gdk3/unstable/GdkDisplayManager.html#gdk-display-manager-get

would suggest that we need to.
No we don't. Which is odd why it works without calling gdk_init, gtk_init, etc. I think it might be simpler to do it exactly the same way as in ContentChild::Init.
Attachment #8784576 - Attachment is obsolete: true
Attachment #8784576 - Flags: review?(andrew)
Attachment #8786247 - Flags: review?(andrew)
Attachment #8786247 - Flags: review?(andrew) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=46f74d107cdf

There are no behavioural changes because this code is only in the gpu process init.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08698ef52412
Initialize gtk in GPU process. r=acomminos
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/08698ef52412
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.