1297845 - Initialize the gdk_default_display in GPU process

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ryan Hunt [:rhunt]]

We need to have gdk_default_display for GL Layers in the GPU process, and this will also help fix the issue where we open multiple display's when we are running on the GPU process in Bug 1289251.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: gdk-default-display.patch

This patch mirrors how the content process initializes gtk (ContentChild::Init), except we only set the default display.

Comment 2

[Andrew Comminos [:acomminos]]

Comment on attachment 8784576 [details] [diff] [review]
gdk-default-display.patch

Review of attachment 8784576 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUParent.cpp
@@ +102,5 @@
> +  if (!display) {
> +    printf_stderr("Error: cannot open display: %s\n", display_name);
> +    return false;
> +  }
> +  gdk_display_manager_set_default_display(gdk_display_manager_get(),

Do we ever call gdk_init (or equivalents) in the GPU process?

https://developer.gnome.org/gdk3/unstable/GdkDisplayManager.html#gdk-display-manager-get

would suggest that we need to.

Comment 3

[Ryan Hunt [:rhunt]]

No we don't. Which is odd why it works without calling gdk_init, gtk_init, etc. I think it might be simpler to do it exactly the same way as in ContentChild::Init.

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: init-gtk-gpu.patch

Comment 5

[Ryan Hunt [:rhunt]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46f74d107cdf

There are no behavioural changes because this code is only in the gpu process init.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08698ef52412
Initialize gtk in GPU process. r=acomminos

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/08698ef52412