Closed
Bug 1297905
Opened 9 years ago
Closed 9 years ago
Remove usage of getAllDisabledHosts in sanitize implementations now that login saving is in the perm. manager
Categories
(Toolkit :: Password Manager, defect, P3)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | unaffected |
| firefox51 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
()
Details
Attachments
(1 file)
Bug 1058438 switched pwmgr to using the permission manager to store disabled hosts and removed the manual iteration from ForgetAboutSite.jsm but didn't update the sanitizers for clear recent history to use the permission manager code path.
The user impact is that the time range selector for clear recent history still has no effect for password manager disabled hosts.
| Comment hidden (mozreview-request) |
|
||
Comment 2•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8784627 [details]
Bug 1297905 - Remove usage of getAllDisabledHosts in sanitize implementations.
https://reviewboard.mozilla.org/r/73978/#review71870
sounds legit!
Attachment #8784627 -
Flags: review?(markh) → review+
|
Assignee | |
Comment 3•9 years ago
|
||
|
||
Comment 4•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8784627 [details]
Bug 1297905 - Remove usage of getAllDisabledHosts in sanitize implementations.
https://reviewboard.mozilla.org/r/73978/#review72206
Thanks Matt! Sorry, I was thinking about some other uses but it turns out I was thinking about a different disabled query.
Attachment #8784627 -
Flags: review?(liuche) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/fx-team/rev/3d534ebc1ac3
Remove usage of getAllDisabledHosts in sanitize implementations. r=liuche,markh
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•