1297906 - -Werror=unused-result causing bustage in suite/

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

bustage in line with the warnings that have been busting us
for some time.

mkdir -p '.deps/'
/usr/bin/ccache /builds/slave/c-cen-t-lnx/build/gcc/bin/g++ -m32 -march=pentiumpro -std=gnu++11 -o nsFeedSniffer.o -c -I/builds/slave/c-cen-t-lnx/build/objdir/dist/stl_wrappers -I/builds/slave/c-cen-t-lnx/build/objdir/dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -I/builds/slave/c-cen-t-lnx/build/suite/feeds/src -I/builds/slave/c-cen-t-lnx/build/objdir/suite/feeds/src  -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include  -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /builds/slave/c-cen-t-lnx/build/objdir/mozilla-config.h -MD -MP -MF .deps/nsFeedSniffer.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -gdwarf-2 -freorder-blocks -Os -fno-omit-frame-pointer  -Werror   /builds/slave/c-cen-t-lnx/build/suite/feeds/src/nsFeedSniffer.cpp
/builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../x86_64-unknown-linux-gnu/bin/as: /lib64/libz.so.1: no version information available (required by /builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../x86_64-unknown-linux-gnu/bin/as)
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp: In member function 'nsresult nsNetscapeProfileMigratorBase::CopySignatureFiles(nsNetscapeProfileMigratorBase::PBStructArray&, nsIPrefService*)':
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:783:90: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
       srcSigFile->SetPersistentDescriptor(nsDependentCString(pref->stringValue));
                                                                                          ^
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:802:65: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
         targetSigFile->GetPersistentDescriptor(descriptorString);
                                                                 ^
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp: In member function 'nsresult nsNetscapeProfileMigratorBase::CopyMailFolderPrefs(nsNetscapeProfileMigratorBase::PBStructArray&, nsIPrefService*)':
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:882:70: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
         targetMailFolder->CreateUnique(nsIFile::DIRECTORY_TYPE, 0777);
                                                                      ^
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:889:68: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
         targetMailFolder->GetPersistentDescriptor(descriptorString);
                                                                    ^
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:906:56: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
         nsDependentCString(pref->stringValue));
                                                        ^
../../../../../suite/profile/migration/src/nsNetscapeProfileMigratorBase.cpp:920:68: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
         targetNewsRCFile->GetPersistentDescriptor(descriptorString);
                                                                    ^
cc1plus: all warnings being treated as errors
make[4]: *** [nsNetscapeProfileMigratorBase.o] Error 1

Comment 1

[Edmund Wong (:ewong)]

Attachment: proposed patch

Comment 2

[Ian Neal]

Comment on attachment 8784636 [details] [diff] [review]
proposed patch

From the looks of Bug 736501 this has been around a while, why is it biting us now?
r/a=me

Comment 3

[Ian Neal]

or is it MOZ_MUST_USE?

Comment 4

[Edmund Wong (:ewong)]

Attachment: proposed patch (v2)

Comment 5

[Ian Neal]

Comment on attachment 8784706 [details] [diff] [review]
proposed patch (v2)

r/a=me

Comment 6

[Edmund Wong (:ewong)]

Attachment: proposed patch (v3)

Third time's a charm.  (was tested on a linux slave... builds ok)

Comment 7

[Edmund Wong (:ewong)]

https://hg.mozilla.org/comm-central/rev/7ca0a0644ba1b5c69d47a840f08a917f66f9546e
Bug 1297906 - Properly respond to the return value. r+a=IanN

Comment 8

[Ian Neal]

Comment on attachment 8784723 [details] [diff] [review]
proposed patch (v3)

retrospective r=me