1297974 - Shutdown hang when Firefox is closed while processing many incoming records

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Somewhat related to bug 1296560, but when processing incoming records. As we process incoming records we catch all exceptions and continue on to the next record. If the exception is a shutdown exception and there are many incoming records, we just continue to spew messages about the error applying records until Firefox is forced closed, creating a shutdown hang crash. We should just rethrow the exception so the loop is terminated.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1297974 - correctly handle shutdown exceptions while applying incoming records.

Review commit: https://reviewboard.mozilla.org/r/74054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74054/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8784713 [details]
Bug 1297974 - correctly handle shutdown exceptions while applying incoming records.

https://reviewboard.mozilla.org/r/74054/#review72190

We already do this in a bunch of places, so fine by me, I think. No worse than a crash.

Consider resetting the file logger, as we do in policies.js, to make sure we don't lose log output.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Consider resetting the file logger, as we do in policies.js, to make sure we
> don't lose log output.

That doesn't seem necessary - this patch causes Sync to fail quickly and I just verified that code in policies.js does see the shutdown exception and doing the flush after logging:

> 1472190313556   Sync.ErrorHandler       ERROR   Sync was interrupted due to the application shutting down

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdcbb0707964
correctly handle shutdown exceptions while applying incoming records. r=rnewman

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cdcbb0707964