1298011 - Synced Tabs sidebar does not show a message to sign in again after password was changed

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P3)

Description

[Liviu Cirdei]

[Affected platforms]
all

[Steps to reproduce]:

1. Sign in to Firefox on 2 devices with the same account.
2. From one device open some tabs and perform a sync.
3. On second device open Sync Tabs sidebar (Menu Bar>View>Sidebars > Synced Tabs). > The tabs are listed in the Sync tabs sidebar.
4. On first device, go to your account and change your password. > Password in changed.
5. Perform a sync.
6. On your second device, on synced tabs sidebar right click and "Sync Now". 

[Expected Result]: 
Sync Tabs sidebar should show a message to sign in again.

[Actual Result]: 
Synced Tabs sidebar does not show a message to sign in again after password is changed. Closing and reopening the sidebar does not fix it.

[Regression range] 
I think this is not a regression, it works like this from the beginning of the implementation of the synced tabs sidebar.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Yeah, this sucks and isn't intentional :(

Comment 2

[Lina Butler [:lina]]

Liviu, could you please post a screenshot of what happens on the second device? What do you see instead of the message to sign in again?

Comment 3

[Liviu Cirdei]

Attachment: video_of_the_issue.mp4

The synced tabs and devices are displayed instead of the sign in message.
I attached a video that shows this.

Comment 4

[Lina Butler [:lina]]

From the triage meeting: there's some discussion around separating password change and deauthorizing a device, so we'll wait for that to crystallize before taking action.

Comment 5

[Edouard Oger [:eoger]]

Attachment: Bug 1298011 - Update the Synced Tabs sidebar UI when account password changed.

Review commit: https://reviewboard.mozilla.org/r/102730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102730/

Comment 6

[Edouard Oger [:eoger]]

This patch listens to the weave:service:login:change event which is fired when a password change has been detected.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8824219 [details]
Bug 1298011 - Update the Synced Tabs sidebar UI when account password changed.

https://reviewboard.mozilla.org/r/102730/#review103092

(oops - this was pending - apparently I forgot to hit "publish" :(

LGTM, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6fcdb398694
Update the Synced Tabs sidebar UI when account password changed. r=markh

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6fcdb398694

Comment 10

[Gerry Chang [:gchang]]

We've built 51 RC. Mark 51 won't fix.

Comment 11

[sriramsubramanian23]

[bugday-20170222] bug verified 
os: Ubuntu 15.10
Browser Version: 41.0.2
I reproduced the bug and its fixed

Comment 12

[Andrei Vaida [:avaida]]

Kanchan, just making sure you're in the loop here.

Comment 13

[Kanchan Kumari QA]

Thanks Andrei!

I have tested this bug fix and found it to to be working fine on 
Version 	53.0b1
Build ID 	20170307064827

After password change on device 1, Synced Tabs sidebar UI on device 2 shows "sign in to sync" message.