After password is changed Synced Tabs panel shows the synced tabs for a second before showing a sign in message

NEW
Unassigned

Status

()

Firefox
Sync
P3
normal
2 years ago
2 years ago

People

(Reporter: Liviu Cirdei, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox51 affected)

Details

(Whiteboard: [sync-quality])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8784801 [details]
video_of_the issue.mp4

[Affected platforms]
Windows 10, Ubuntu 15.04, Mac 10.10

[Steps to reproduce]:

1. Sign in to Firefox on 2 devices with the same account.
2. From one device open some tabs and perform a sync.
3. On second device open Sync Tabs panel (Menu > Synced Tabs). > The tabs are listed in the Synced tabs panel.
4. On first device, go to your account and change your password. > Password in changed.
5. On your second device, go to Menu > Synced Tabs.
 
[Expected Result]: 
A Sign in message should be shown to user so he can sign in again.

[Actual Result]: 
Synced Tabs panel first shows the synced tabs for a second then the message to sign in again.

See the attached video.
I'm not too bothered by this - think of it as a "lazy" update :)

Ryan, what do you think?
Flags: needinfo?(rfeeley)
Well spotted. A little jarring. Mark, do we hold onto the list of Synced Tabs indefinitely? I'm wondering if this state could use a design that shows the list, but simply changes the "Sync Now" option with something like "Reconnect to Sync…" (I'd probably want to have the yellow warning triangle to the left of it).
Flags: needinfo?(rfeeley) → needinfo?(markh)
(In reply to Ryan Feeley [:rfeeley] from comment #2)
> Well spotted. A little jarring. Mark, do we hold onto the list of Synced
> Tabs indefinitely?

What we do is always keep the last set of tabs we fetched around so we can show them immediately, then as the menu opens we refresh the list (which is asynchronous and may take some time.

So that's what we are seeing here - we show the last set of tabs, then quickly detect the new login state and change to the existing "please sign in" state.

> I'm wondering if this state could use a design that shows
> the list, but simply changes the "Sync Now" option with something like
> "Reconnect to Sync…" (I'd probably want to have the yellow warning triangle
> to the left of it).

We could do that (although it would still take a second or so to change the button), but TBH I don't think it is worth it - it's an edge-case that the vast majority of users will never see. But I'm happy for you to put a design up and get it added to our backlog if you think it should be a priority.
Flags: needinfo?(markh)
Priority: -- → P3
Whiteboard: [sync-quality]
You need to log in before you can comment on or make changes to this bug.