Closed Bug 1298016 Opened 3 years ago Closed 3 years ago

Identity popup's security view footer should inherit the text color instead of using ButtonText

Categories

(Firefox :: Theme, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Iteration:
51.2 - Aug 29
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: Antora, Mentored)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/annotate/7963ebdd52b9/browser/themes/shared/controlcenter/panel.inc.css#l290

When using 'background-color: transparent;', effectively using the parent's background, we need to inherit the color from the parent as well.
Hello Dao, 
I am interested in fixing this bug. 
Can you please assign this to me ? and yes, shall I just set the color to 'inherit' in line number #290 ?

Thanks!
Flags: needinfo?(dao+bmo)
(In reply to Saheda Reza [:Antora] from comment #1)
> Hello Dao, 
> I am interested in fixing this bug. 
> Can you please assign this to me ? and yes, shall I just set the color to
> 'inherit' in line number #290 ?
> 
> Thanks!

Yes.
Assignee: nobody → saheda.antora
Flags: needinfo?(dao+bmo)
Here is the patch.
Thanks.
Attachment #8785431 - Flags: review?(dao+bmo)
Comment on attachment 8785431 [details] [diff] [review]
color_inheritance.patch

Looks good!
Attachment #8785431 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe09013da0a
Identity popup's security view footer color changed to inherit instead of using ButtonText; r=dao
https://hg.mozilla.org/mozilla-central/rev/7fe09013da0a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 51.2 - Aug 29
You need to log in before you can comment on or make changes to this bug.