Closed Bug 1298016 Opened 5 years ago Closed 5 years ago
Identity popup's security view footer should inherit the text color instead of using Button
https://hg.mozilla.org/mozilla-central/annotate/7963ebdd52b9/browser/themes/shared/controlcenter/panel.inc.css#l290 When using 'background-color: transparent;', effectively using the parent's background, we need to inherit the color from the parent as well.
Hello Dao, I am interested in fixing this bug. Can you please assign this to me ? and yes, shall I just set the color to 'inherit' in line number #290 ? Thanks!
(In reply to Saheda Reza [:Antora] from comment #1) > Hello Dao, > I am interested in fixing this bug. > Can you please assign this to me ? and yes, shall I just set the color to > 'inherit' in line number #290 ? > > Thanks! Yes.
Assignee: nobody → saheda.antora
Here is the patch. Thanks.
Attachment #8785431 - Flags: review?(dao+bmo)
Comment on attachment 8785431 [details] [diff] [review] color_inheritance.patch Looks good!
Attachment #8785431 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe09013da0a Identity popup's security view footer color changed to inherit instead of using ButtonText; r=dao
You need to log in before you can comment on or make changes to this bug.