1298017 - Unable to type Russian letter "б" in tags

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Editing, enhancement, P5)

Description

[snejugal]

What did you do?
================
Pressed "б" (in Russian layout, comma in English) on my keyboard.

What happened?
==============
A new tag appeared.

What should have happened?
==========================
A Russian letter "б" should have written.

Is there anything else we should know?
======================================
Other layouts may also have a letter instead of a comma on this button.

Comment 1

[John Whitlock [:jwhitlock]]

I'm not sure what the issue is.  I think this is the page:

https://developer.mozilla.org/ru/docs/Web/HTML/Optimizing_Your_Pages_for_Speculative_Parsing

The one change appears to be adding document tags, which appear at the end of the page:

HTML
HTML5
Веб-разработка ("Web Development" in Russian)
Продвинутый ("Advanced" in Russian)

This also seems to be the correct tag list (although it makes me sad about our tag implementation).

What was the task you were working on when you pressed "б"? What change were you trying to make?

Comment 2

[snejugal]

(In reply to John Whitlock [:jwhitlock] from comment #1)
> I'm not sure what the issue is.  I think this is the page:
> 
> https://developer.mozilla.org/ru/docs/Web/HTML/
> Optimizing_Your_Pages_for_Speculative_Parsing
> 
> The one change appears to be adding document tags, which appear at the end
> of the page:
> 
> HTML
> HTML5
> Веб-разработка ("Web Development" in Russian)
> Продвинутый ("Advanced" in Russian)
> 
> This also seems to be the correct tag list (although it makes me sad about
> our tag implementation).
> 
> What was the task you were working on when you pressed "б"? What change were
> you trying to make?

I was adding tags to the page (there were no them). I had to copy "б" to write the tags.

Comment 3

[John Whitlock [:jwhitlock]]

Thank you, I think that makes sense now.

In English, the tag field JavaScript takes the comma "," keypress and says "the user intended to start a new tag".  My guess is the JS is still interpreting the Russian "б" keypress as an English comma.

More investigation is needed to determine if this is Kuma JS or 3rd party JS code that needs to be modified or updated.

Comment 4

[snejugal]

(In reply to John Whitlock [:jwhitlock] from comment #3)
> Thank you, I think that makes sense now.
> 
> In English, the tag field JavaScript takes the comma "," keypress and says
> "the user intended to start a new tag".  My guess is the JS is still
> interpreting the Russian "б" keypress as an English comma.
> 
> More investigation is needed to determine if this is Kuma JS or 3rd party JS
> code that needs to be modified or updated.

I want to add that if I press Shift + / (it writes a comma in the Russian layout), a new tag doesn't appear, just a comma is written.

Comment 5

[Stephanie Hobson [:shobson]]

Ugh. Super annoying :( 

This is a problem with the jQuery UI Tag-it plug in we are using:
https://github.com/aehlke/tag-it/issues/324

I've subscribed to the issue and will update our version when they update.

I'm sure this is a problem for other non-default keyboard configuration as well :(

Comment 6

[Eric Shepherd [:sheppy]]

For what it's worth, it appears that the problem is on line 244 of js/tag-it.js:

 (event.which === $.ui.keyCode.COMMA && event.shiftKey === false) ||

This is relying on the locale-independent value of the key to identify the key, but that value is based on the key's position on the keyboard, not the character on the key. This line should actually be:

 (event.key === ",")

Except that event.key is newer and may not be available on all the browsers they want to support.

Comment 7

[John Whitlock [:jwhitlock]]

Upstream appears to be an abandoned project, with the last commit in Nov 2014, many open issues, and many open PRs.  We may need to fork and patch, research alternatives, or remove the widget entirely and make it a "plain" text field.

Comment 10

[John Whitlock [:jwhitlock]]

There was an attempt to fix this bug in PR 5027, but it had problems and was not reviewable. See https://github.com/mozilla/kuma/pull/5027#issuecomment-432010001 for some ideas if you want to solve this issue.

The reasons for this tag handler is that we allow free entry of tags, and "translated" tags (which have no linkage to the English tag). I believe these are both bad features. The page slug is useful for most categorization needs, so free tagging is not as useful as on WikiPedia, where the page structure is flat. For the remaining use cases, the list of tags should be curated and small and English-only, and translated at render time.

Comment 12

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.