Filed by: rvandermeulen [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=3369484&repo=mozilla-aurora https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-aurora-macosx64-debug/1472095526/mozilla-aurora_yosemite_r7-debug_test-web-platform-tests-6-bm106-tests1-macosx-build12.txt.gz
3 years ago
Priority: -- → P5
Fixed by backing out bug 1128069 part 7 from Aurora.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #2) > Fixed by backing out bug 1128069 part 7 from Aurora. Not sure why I thought that would help given that this is failing an entirely different test. Jean-Yves, what do you recommend doing here? Is there a test fix we can uplift to Aurora to make this go away or should we disable the test?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We could uplift most of bug 1293613 and adjust some result expectations for the new features not currently implemented in 50 and only in 51 (like testing/web-platform/tests/media-source/mediasource-liveseekable.html). We can keep the disable tests, disabled. those tests are mostly wrong, and relying on undefined behaviour, that's why they intermittently fail. bug 1293613 attempted to fix most of them to remove the reliance on chromium-only behaviour.
I have to say, disabling the test seems like the most palatable option at this point if it's not a great test to begin with.
I think the particular commit that is fixing those particular errors is https://hg.mozilla.org/mozilla-central/rev/9f514918f33580ea6c4f9d765aca0f8d6476eec0 It's what's causing the: TypeError: must be string or pinned buffer, not bytearray which leads to TEST-UNEXPECTED-TIMEOUT | /media-source/mediasource-play-then-seek-back.html | expected OK but disabling the test is fine by me otherwise.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7) > Worth a shot! > https://hg.mozilla.org/releases/mozilla-aurora/rev/6ea5133aab19 Didn't help, unfortunately. ni? myself to skip the test on 50.
Fixed as it's ever going to be.
You need to log in before you can comment on or make changes to this bug.