Container tab menu on long press add menu not present after customize

NEW
Assigned to

Status

()

P3
normal
2 years ago
a year ago

People

(Reporter: jkt, Assigned: jkt)

Tracking

(Blocks: 1 bug)

53 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 affected, firefox53 affected, firefox57 fix-optional)

Details

(Whiteboard: [domsecurity-active][userContextId])

(Assignee)

Description

2 years ago
After the longpress button goes live there is a follow up issue that once the user customises the browser to not have the add button; placing it back would not have the long press functionality.
(Assignee)

Updated

2 years ago
Whiteboard: [domsecurity-active][userContextId]

Updated

2 years ago
Priority: -- → P3

Comment 1

2 years ago
jkt, is this still valid?
Flags: needinfo?(jkt)
I don't think this is an issues anymore. I went through the test cases listed below on all three platforms and I couldn't reproduce the original problem.

Hopefully one of the cases listed below was the one that Jonathan was originally running into.

Test Cases Used:

* moving the new tab button (+) into the hamburger menu and than moving it back to the original location
* moving the new tab button (+) into the customization window and than moving it back into the original location
* moved the new tab button (+) into other locations
* ensured that the new tab button (+) is still working after using "Restore Defaults"

Platforms Used:

* macOS 10.12.1 x64 - PASSED
* Win 10 x64 VM - PASSED
* Ubuntu 16.04 x64 VM - PASSED

Build being used:
* https://archive.mozilla.org/pub/firefox/nightly/2016/11/2016-11-17-03-02-12-mozilla-central/
(Assignee)

Comment 3

2 years ago
I think the bug is related to Bug 1317317 but I'm not sure that will fix it.

To my understanding the STR would be:
- disable containers
- drag new tab to customise window
- enable containers
- drag back out
- container menu won't be present as it's added only if it is present in the browser when enabled
Depends on: 1317317
Flags: needinfo?(jkt)
Thanks Jonathan, I can reproduce this on both fx53 and fx52 on all the current platforms using the STR from comment#3.
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → 53 Branch
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox53: --- → affected
(Assignee)

Updated

2 years ago
Assignee: nobody → jkt
(Assignee)

Updated

2 years ago
Blocks: 1191418
You need to log in before you can comment on or make changes to this bug.