1298064 - Container tab menu on long press add menu not present after customize

Status: NEW

(Core :: DOM: Security, defect, P3)

Description

[Jonathan Kingston [:jkt] he/him]

After the longpress button goes live there is a follow up issue that once the user customises the browser to not have the add button; placing it back would not have the long press functionality.

Comment 1

[Tanvi Vyas[:tanvi]]

jkt, is this still valid?

Comment 2

[Kamil Jozwiak [:kjozwiak]]

I don't think this is an issues anymore. I went through the test cases listed below on all three platforms and I couldn't reproduce the original problem.

Hopefully one of the cases listed below was the one that Jonathan was originally running into.

Test Cases Used:

* moving the new tab button (+) into the hamburger menu and than moving it back to the original location
* moving the new tab button (+) into the customization window and than moving it back into the original location
* moved the new tab button (+) into other locations
* ensured that the new tab button (+) is still working after using "Restore Defaults"

Platforms Used:

* macOS 10.12.1 x64 - PASSED
* Win 10 x64 VM - PASSED
* Ubuntu 16.04 x64 VM - PASSED

Build being used:
* https://archive.mozilla.org/pub/firefox/nightly/2016/11/2016-11-17-03-02-12-mozilla-central/

Comment 3

[Jonathan Kingston [:jkt] he/him]

I think the bug is related to Bug 1317317 but I'm not sure that will fix it.

To my understanding the STR would be:
- disable containers
- drag new tab to customise window
- enable containers
- drag back out
- container menu won't be present as it's added only if it is present in the browser when enabled

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Thanks Jonathan, I can reproduce this on both fx53 and fx52 on all the current platforms using the STR from comment#3.

Comment 5

[Firefox Bug Husbandry Bot]

Bulk change per https://bugzilla.mozilla.org/show_bug.cgi?id=1401020