Closed Bug 1298134 Opened 3 years ago Closed 3 years ago

VRDisplayOculus initializes members out of declaration order

Categories

(Core :: Graphics, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

This causes warnings with clang-cl:

 0:34.26 c:/m-c/gfx/vr/gfxVROculus.cpp(326,5):  warning: field 'mInputLayout' will be initialized after field 'mLinearSamplerState' [-Wreorder]
 0:34.26   , mInputLayout(nullptr)
 0:34.26     ^
Assignee: nobody → nfroyd
Comment on attachment 8789767 [details] [diff] [review]
fix member initialization order in VRDisplayOculus

Review of attachment 8789767 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, thanks for spotting it.
Attachment #8789767 - Flags: review?(kgilbert) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af263033e78
fix member initialization order in VRDisplayOculus; r=kip
https://hg.mozilla.org/mozilla-central/rev/4af263033e78
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.