Closed Bug 1298170 Opened 8 years ago Closed 8 years ago

Fix remaining broken behavior in check_for_crash()

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1299216

People

(Reporter: whimboo, Unassigned, Mentored)

Details

(Whiteboard: [lang=py]) 

The check_for_crash() method of the Marionette object has some weird behavior:

1. returncode is set to None but never updated, so the second if condition will never evaluate to true.

2. name is set to None but never updated

3. We only set crashed to true if we have our own instance. Shouldn't we also do it in case Marionette connected to an already running process?

Here the appropriate code:

https://dxr.mozilla.org/mozilla-central/rev/7963ebdd52b93f96b812eff2eab8d94097147b9c/testing/marionette/client/marionette_driver/marionette.py#736
Hi, I would like to work on this bug. However, I am not clear how to check wether Marionette us connected an already running process, since I haven't used Marionette before. Could you point me in the right direction?
Thanks a lot
Flags: needinfo?(hskupin)
As best is when you build your own build of Firefox with Marionette enabled, and once done you can start it with "./mach run". Then use "./mach marionette-test --address 2828" to connect to this already running instance of Firefox.
Flags: needinfo?(hskupin)
Given that we haven't had an update on this bug and I actually need this behavior fixed for bug 1299216, I will take care of it over there.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.