Closed
Bug 1298209
Opened 7 years ago
Closed 7 years ago
Some small refactorings in layout code
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(7 files)
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
No description provided.
|
Assignee | |
Updated•7 years ago
|
Summary: Small refactorings in nsIFrame::BuildDisplayListForStackingContext → Some small refactorings in layout code
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785040 [details] Bug 1298209 - Use mFrame instead of Frame() because it's less confusing. https://reviewboard.mozilla.org/r/74348/#review72588
Attachment #8785040 -
Flags: review?(matt.woodrow) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785041 [details] Bug 1298209 - Fix indent. https://reviewboard.mozilla.org/r/74350/#review72590
Attachment #8785041 -
Flags: review?(matt.woodrow) → review+
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785042 [details] Bug 1298209 - Create variables for extend3DContext and hasPerspective. https://reviewboard.mozilla.org/r/74352/#review72592
Attachment #8785042 -
Flags: review?(matt.woodrow) → review+
|
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785046 [details] Bug 1298209 - Remove unused mIsPerspectiveItem. https://reviewboard.mozilla.org/r/74360/#review72594
Attachment #8785046 -
Flags: review?(matt.woodrow) → review+
|
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785045 [details] Bug 1298209 - Remove unused mIsCaret. https://reviewboard.mozilla.org/r/74358/#review72596
Attachment #8785045 -
Flags: review?(matt.woodrow) → review+
|
|
||
Comment 13•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785044 [details] Bug 1298209 - Use Maybe<nsRect> for nsIFrame::GetClipPropClipRect. https://reviewboard.mozilla.org/r/74356/#review72598
Attachment #8785044 -
Flags: review?(matt.woodrow) → review+
|
|
||
Comment 14•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785043 [details] Bug 1298209 - Make clip capturing easier to understand. https://reviewboard.mozilla.org/r/74354/#review72600 I love this.
Attachment #8785043 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 15•7 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/caf79ae762db Use mFrame instead of Frame() because it's less confusing. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/2819165214b1 Fix indent. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/da9997da481c Create variables for extend3DContext and hasPerspective. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/66c244af565d Make clip capturing easier to understand. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/12c0e3f66728 Use Maybe<nsRect> for nsIFrame::GetClipPropClipRect. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/ad4ae55bee47 Remove unused mIsCaret. r=mattwoodrow https://hg.mozilla.org/integration/mozilla-inbound/rev/a2c37ec9bae2 Remove unused mIsPerspectiveItem. r=mattwoodrow
|
||
Comment 16•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/caf79ae762db https://hg.mozilla.org/mozilla-central/rev/2819165214b1 https://hg.mozilla.org/mozilla-central/rev/da9997da481c https://hg.mozilla.org/mozilla-central/rev/66c244af565d https://hg.mozilla.org/mozilla-central/rev/12c0e3f66728 https://hg.mozilla.org/mozilla-central/rev/ad4ae55bee47 https://hg.mozilla.org/mozilla-central/rev/a2c37ec9bae2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•