consider moving entire ship-it api.py from tools to shipitapi python package and have release runner use it

NEW
Unassigned

Status

P5
normal
2 years ago
8 months ago

People

(Reporter: mtabara, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
In bug 1288434 we needed to share the code from http://hg.mozilla.org/build/tools/file/tip/lib/python/kickoff/api.py in a mozharness script. We had three options:

1. to duplicate code in mozharness script
2. to use tools repo in the mozharness script
3. to extract the logic in a Pypi package and use it from there in both places (tools and mozharness).

Eventually we went with the third option and https://pypi.python.org/pypi/shipitapi was born. For the moment it only contains the base API class and the Release one. 

TODOs:
* consider adding the L10n and Releases classes as well in the shipitapi package
* tweak release runner to use the shipitapi package instead of the api.py file from kickoff
You can do something similar to http://hg.mozilla.org/build/tools/rev/f7c95836d626 we did for retry. The basic idea is to copy the library into lib/python/vendor and adjust the usage. This way we would know that if we touch something in vendor, we would want to upstream the changes.
Priority: -- → P2
Assignee: mtabara → nobody
Priority: P2 → P5
You need to log in before you can comment on or make changes to this bug.