1298365 - After restart with Add-ons disabled: NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService] nsUrlClassifierListManager.js:80

Status: NEW

(Toolkit :: Safe Browsing, defect, P3)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160825030226

Steps to reproduce:

1. Start Nightly
2. menubar > Help > Restart with Add-ons Disabled...
3. Check error in Browser Console after restart


Actual results:

After restart with Add-ons disabled, the following error occurs two times.

NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]	nsUrlClassifierListManager.js:80



Expected results:

Restart with Add-ons disabled without error

Comment 1

[Benjamin Smedberg]

Does this error seem to affect anything visible to the user? ISTR seeing this on a fairly regular basis.

I'm confused about this because nsUrlClassifierListManager.js only has 53 lines. It might be good to attach the browser toolbox debugger and get sources and a stack for this.

Comment 2

[magicp]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #1)
> Does this error seem to affect anything visible to the user? ISTR seeing
> this on a fairly regular basis.
> 
> I'm confused about this because nsUrlClassifierListManager.js only has 53
> lines. It might be good to attach the browser toolbox debugger and get
> sources and a stack for this.

Can you reproduce this? nsUrlClassifierListManager.js has 631 lines in a latest Nightly!

Comment 3

[Benjamin Smedberg]

Oh I see, there's a preprocessing #include that changes it.

This appears to be intentional, when we're in safe mode: http://searchfox.org/mozilla-central/rev/6536590412ea212c291719d1ed226fae65a0f917/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1234

We could decide to WONTFIX this, or do extra checking in the JS to avoid reporting an error when we're in safe mode.

Comment 4

[magicp]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #3)

> We could decide to WONTFIX this, or do extra checking in the JS to avoid
> reporting an error when we're in safe mode.

In safe mode, users will be confused by the error.

Comment 5

[Intermittent Failures Robot]

1 failures in 943 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1298365&startday=2017-09-18&endday=2017-09-24&tree=all

Comment 6

[Nikki Sharpley [:nikkis]]

Hello! I tried to reproduce this bug but was unable to. I assume, as it is quite old, that this has already been resolved? If not, could you please let me know how best to reproduce the error? I'd love to contribute. Thanks!

Comment 7

[Dimi Lee [:dimi]]

(In reply to Nikki from comment #6)

Hello! I tried to reproduce this bug but was unable to. I assume, as it is quite old, that this has already been resolved? If not, could you please let me know how best to reproduce the error? I'd love to contribute. Thanks!

Hi Nikki,
I'll check if this is still reproducible (maybe before end of this week) and let you know.

Comment 8

[Nikki Sharpley [:nikkis]]

Thanks Dimi!

Comment 9

[afshan.shokath]

Hello,
Can I know if this is still open and if I can be assigned this issue? I am an outreachy applicant.

Comment 10

[Dimi Lee [:dimi]]

Hi Nikki,
I tested and this is still reproducible
The error message:

NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIUrlClassifierDBService.getTables] UrlClassifierListManager.jsm:327

Hi afshan,
You don't have to be "assigned" by someone to work on a bug. If a bug's status is New and there is no assignee, you can just take and work on it.

Comment 11

[afshan.shokath]

Hello, (In reply to Dimi Lee [:dimi][:dlee] from comment #10)

Hi Nikki,
I tested and this is still reproducible
The error message:

NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIUrlClassifierDBService.getTables] UrlClassifierListManager.jsm:327

Hi afshan,
You don't have to be "assigned" by someone to work on a bug. If a bug's status is New and there is no assignee, you can just take and work on it.

Hello Dimi,
Thank you for letting me know that. I am a noob here. I am an Outreachy applicant and I am hunting bugs write now and if no one is working on it I am asking it to be assigned to me and trying to work on it, if Nikki is not working on it can you please assign it to me?

Hello Nikki,
Are you taking up or working on this bug? If not I would like to take it up.

Comment 12

[afshan.shokath]

(In reply to Dimi Lee [:dimi][:dlee] from comment #10)

Hi Nikki,
I tested and this is still reproducible
The error message:

NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIUrlClassifierDBService.getTables] UrlClassifierListManager.jsm:327

Hi afshan,
You don't have to be "assigned" by someone to work on a bug. If a bug's status is New and there is no assignee, you can just take and work on it.

Hello Dimi,
Thank you for letting me know that. Apparently I am a noob here and I was told to check if someone is already working on the bug before taking it up. If no one is working on it, get it assigned to myself and then work on it. I am an Outreachy applicant and I am in bug hunting stage right now. So if no one is working on it can you assign it to me? Just in case there should be no confusion.

Hello Nikki,
do you want to take this up?

Comment 13

[Nikki Sharpley [:nikkis]]

Hi Dimi Lee. Thanks so much for checking!

I was going to work on this one for my application too, but I've been lucky enough to score some other bugs to work on. I know a lot have been snapped up pretty quickly, so you are most welcome to this one if you still want it, Afshan. Good luck on your application too! :)

Comment 14

[afshan.shokath]

(In reply to Nikki from comment #13)

Hi Dimi Lee. Thanks so much for checking!

I was going to work on this one for my application too, but I've been lucky enough to score some other bugs to work on. I know a lot have been snapped up pretty quickly, so you are most welcome to this one if you still want it, Afshan. Good luck on your application too! :)

Thank you Nikki,
I am going to work on it then.

Comment 15

[afshan.shokath]

Hello Dimi Lee,
I was able to reproduce this issue on mac machine, Firefox nightly 67.0a1.

The following errors occurs on my machine:

NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED)[nsIUrlClassifierDBService.getTables] UrlClassifierListManager.jsm:327

(intermediate value).messages is undefined ASRouter.jsm:116

Comment 16

[afshan.shokath]

I was also able to reproduce this on Firefox 65.0.1

Error:
NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]

Comment 17

[afshan.shokath]

So, I am unable to reproduce the issue now in both Firefox nightly 67.0a1 and Firefox 65.0.1. It seemed to have resolved for some reason while I was working on it.

Comment 18

[afshan.shokath]

I was able to reproduce it again. So I am working on it again.

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.