Status

()

Firefox for Android
Theme and Visual Design
P4
normal
VERIFIED FIXED
9 months ago
4 months ago

People

(Reporter: ItielMaN, Unassigned)

Tracking

(Blocks: 1 bug, {rtl})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
Created attachment 8785291 [details]
Undo button on the wrong side

In RTL builds, the toast notifications ("Closed <Tab name>   UNDO") should be RTL'd.
Currently the <Tab name> is bidirectional (which is good), but the "UNDO" button should appear on the left side of the notification.
LTR builds have it on the right, so RTL should have it on the opposite side.

Screenshot attached.
(Reporter)

Comment 1

9 months ago
Needless to say, the "UNDO" was just an example.
The same patch should be applied to all other toast notifications with a button in them.
(Reporter)

Comment 2

9 months ago
After discussing with the specs author (:Arash-M) of the meta bug 702845 regarding the directionality of the button, he agreed with me that it should be moved to the left.
(Reporter)

Comment 3

6 months ago
Seems to be fixed in latest Nightly (26.11.16).
Still not closing as RESOLVED FIXED as the notifications aren't localized yet and I don't know how they'll look once they will be.
(Reporter)

Comment 4

6 months ago
Fixed in latest Nightly builds on Samsung Galaxy S5 Android 6.0.1.
Can someone verify this is fixed also on tablets?
(Reporter)

Updated

6 months ago
Flags: needinfo?(reza.habibi2008)
Flags: needinfo?(mousavi.arash)
Flags: needinfo?(khaledhosny)
(Reporter)

Updated

6 months ago
Version: 48 Branch → unspecified

Comment 5

6 months ago
Seems fixed on the tablet as well.
Flags: needinfo?(khaledhosny)
(Reporter)

Comment 6

6 months ago
(In reply to Khaled Hosny from comment #5)
> Seems fixed on the tablet as well.

Thank you!
Closing as RESOLVED FIXED then.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Flags: needinfo?(reza.habibi2008)
Flags: needinfo?(mousavi.arash)
Resolution: --- → FIXED

Comment 7

4 months ago
Verified as per last comments/.
Status: RESOLVED → VERIFIED
Blocks: 1319302
You need to log in before you can comment on or make changes to this bug.