1298379 - RTL toast notifications

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P4)

Description

[Itiel]

Attachment: Undo button on the wrong side

In RTL builds, the toast notifications ("Closed <Tab name>   UNDO") should be RTL'd.
Currently the <Tab name> is bidirectional (which is good), but the "UNDO" button should appear on the left side of the notification.
LTR builds have it on the right, so RTL should have it on the opposite side.

Screenshot attached.

Comment 1

[Itiel]

Needless to say, the "UNDO" was just an example.
The same patch should be applied to all other toast notifications with a button in them.

Comment 2

[Itiel]

After discussing with the specs author (:Arash-M) of the meta bug 702845 regarding the directionality of the button, he agreed with me that it should be moved to the left.

Comment 3

[Itiel]

Seems to be fixed in latest Nightly (26.11.16).
Still not closing as RESOLVED FIXED as the notifications aren't localized yet and I don't know how they'll look once they will be.

Comment 4

[Itiel]

Fixed in latest Nightly builds on Samsung Galaxy S5 Android 6.0.1.
Can someone verify this is fixed also on tablets?

Comment 5

[Khaled Hosny]

Seems fixed on the tablet as well.

Comment 6

[Itiel]

(In reply to Khaled Hosny from comment #5)
> Seems fixed on the tablet as well.

Thank you!
Closing as RESOLVED FIXED then.

Comment 7

[Ioana Chiorean]

Verified as per last comments/.