Closed Bug 1298379 Opened 4 years ago Closed 4 years ago

RTL toast notifications

Categories

(Firefox for Android :: Theme and Visual Design, defect, P4)

Unspecified
Android
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: itiel_yn8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: rtl)

Attachments

(1 file)

In RTL builds, the toast notifications ("Closed <Tab name>   UNDO") should be RTL'd.
Currently the <Tab name> is bidirectional (which is good), but the "UNDO" button should appear on the left side of the notification.
LTR builds have it on the right, so RTL should have it on the opposite side.

Screenshot attached.
Needless to say, the "UNDO" was just an example.
The same patch should be applied to all other toast notifications with a button in them.
After discussing with the specs author (:Arash-M) of the meta bug 702845 regarding the directionality of the button, he agreed with me that it should be moved to the left.
Seems to be fixed in latest Nightly (26.11.16).
Still not closing as RESOLVED FIXED as the notifications aren't localized yet and I don't know how they'll look once they will be.
Fixed in latest Nightly builds on Samsung Galaxy S5 Android 6.0.1.
Can someone verify this is fixed also on tablets?
Flags: needinfo?(reza.habibi2008)
Flags: needinfo?(mousavi.arash)
Flags: needinfo?(khaledhosny)
Version: 48 Branch → unspecified
Seems fixed on the tablet as well.
Flags: needinfo?(khaledhosny)
(In reply to Khaled Hosny from comment #5)
> Seems fixed on the tablet as well.

Thank you!
Closing as RESOLVED FIXED then.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(reza.habibi2008)
Flags: needinfo?(mousavi.arash)
Resolution: --- → FIXED
Verified as per last comments/.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.