Closed Bug 1298383 Opened 3 years ago Closed Last year

clang-cl warning: unhandled enum values in switches in FilterNodeD2D1.cpp

Categories

(Core :: Graphics, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: froydnj, Assigned: dmajor)

References

Details

Attachments

(1 file)

clang-cl complains thusly:

 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(167,11):  warning: 19 enumeration values not handled in switch: 'FLOOD', 'TILE', 'TABLE_TRANSFER'... [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(211,11):  warning: 25 enumeration values not handled in switch: 'BLEND', 'TRANSFORM', 'COLOR_MATRIX'... [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(236,11):  warning: enumeration values 'PREMULTIPLY' and 'UNPREMULTIPLY' not handled in switch [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(451,11):  warning: 25 enumeration values not handled in switch: 'BLEND', 'TRANSFORM', 'COLOR_MATRIX'... [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(465,11):  warning: enumeration value 'CONVOLVE_MATRIX' not handled in switch [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
Assignee: nobody → dmajor
Attachment #8961437 - Flags: review?(bas)
Attachment #8961437 - Flags: review?(bas) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2df9a2e7348
Add default cases to appease clang-cl's -Wswitch. r=Bas
https://hg.mozilla.org/mozilla-central/rev/b2df9a2e7348
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.