1298383 - clang-cl warning: unhandled enum values in switches in FilterNodeD2D1.cpp

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nathan Froyd [:froydnj]]

clang-cl complains thusly:

 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(167,11):  warning: 19 enumeration values not handled in switch: 'FLOOD', 'TILE', 'TABLE_TRANSFER'... [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(211,11):  warning: 25 enumeration values not handled in switch: 'BLEND', 'TRANSFORM', 'COLOR_MATRIX'... [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(236,11):  warning: enumeration values 'PREMULTIPLY' and 'UNPREMULTIPLY' not handled in switch [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(451,11):  warning: 25 enumeration values not handled in switch: 'BLEND', 'TRANSFORM', 'COLOR_MATRIX'... [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^
 0:32.22 c:/m-c/gfx/2d/FilterNodeD2D1.cpp(465,11):  warning: enumeration value 'CONVOLVE_MATRIX' not handled in switch [-Wswitch]
 0:32.22   switch (aType) {
 0:32.22           ^

Comment 1

[(Away)]

Attachment: Add default cases to appease clang-cl's -Wswitch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2df9a2e7348
Add default cases to appease clang-cl's -Wswitch. r=Bas

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b2df9a2e7348