Add RTL alignment to text in the Private Tab welcome page on Android

VERIFIED FIXED in Firefox 53

Status

()

VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: itiel_yn8, Assigned: tomer)

Tracking

(Blocks: 1 bug, {rtl})

Trunk
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(URL)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
In RTL builds (tested on Hebrew build, should also happen on other RTL languages builds) when opening a Private Tab, the text is aligned to the left, resulting in the <brandShortName> and the punctuation marks (one '+' sign, 2 dots and one question mark) to appear on the wrong side.
We should add RTL alignment to the text in the Private Tab welcome page.

Screenshot with the issue attached.
(Reporter)

Comment 1

3 years ago
The same patch should be applied to when opening about:privatebrowsing in a non-Private tab.
(Reporter)

Updated

3 years ago
Priority: -- → P4
(Reporter)

Comment 2

2 years ago
Still an issue on latest Nightly builds.
(Reporter)

Updated

2 years ago
Version: 48 Branch → unspecified
(Assignee)

Updated

2 years ago
Assignee: nobody → tomer.moz.bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Posted patch patch (obsolete) — Splinter Review
(Assignee)

Updated

2 years ago
Attachment #8817001 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Priority: P4 → --
Summary: Add RTL alignment to text in the Private Tab welcome page → Add RTL alignment to text in the Private Tab welcome page on Android
(Assignee)

Updated

2 years ago
Attachment #8817021 - Flags: review?(rnewman)
Attachment #8817021 - Flags: review?(rnewman) → review?(s.kaspari)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8817021 [details]
bug 1298385 Add RTL alignment to text in the Private Tab welcome page

https://reviewboard.mozilla.org/r/97452/#review99400
Attachment #8817021 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/572045e55263
Add RTL alignment to text in the Private Tab welcome page r=sebastian
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/572045e55263
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Reporter)

Comment 8

2 years ago
Working okay in latest Nightly build.

Comment 9

2 years ago
AR Fennec 53.0a1 2017-01-18 Pixel Android 7.1.1

Comment 10

2 years ago
Verified as fixed per above last two comments
Status: RESOLVED → VERIFIED
QA Contact: ioana.chiorean
Hardware: Unspecified → All
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.