Closed Bug 1298399 Opened 8 years ago Closed 7 years ago

Remove ?document_saved so that only nice URLs get shared

Categories

(developer.mozilla.org Graveyard :: Wiki pages, enhancement)

Product:
developer.mozilla.org Graveyard
Component:
Wiki pages
Platform:
All
Other
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: fs, Assigned: shobson)

Details

(Keywords: in-triage, Whiteboard: [specification][type:bug]) 

What did you do?
================
1. Edited a page
2. Saved a page

What happened?
==============
?document_saved=true is appended.

What should have happened?
==========================
?document_saved=true could go away maybe?

Is there anything else we should know?
======================================
Saw URLs with "?document_saved=true" shared in IRC, Bugzilla. Wondered why this is and filed this bug.
Yes please. This is part of the updated save code, I'm sure, but we've had to deal with URL cruft before. It results in funky looking URLs everywhere; plus I worry that this might confuse MDN's code some since share links right after saving changes all the time.
Severity: normal → enhancement
Keywords: in-triage
I often want to copy the link or a part of it of a saved article to use it in another related article. With this new parameter it gets more cumbersome to do so.

An alternative to the URL parameter could be a cookie.

Sebastian
As far as I remember, this ``document_saved=true`` parameter is introduced by bug 1268609. This parameter is necessary because with this parameter we understand the page is saved and so we delete the draft.
So removing the parameter will break discarding the draft.

So if its a must need fix, we need to find out another way to discard draft.
(In reply to Safwan Rahman (:safwan) from comment #3)
> So if its a must need fix, we need to find out another way to discard draft.

As mentioned in comment 17 I often need to work with the URL after I saved the article, so, this this indeed requires fixing, IMO.

After thinking more about alternatives, I think the best way would be to include some JavaScript in the response, which removes the draft and is only included in the response of a successfully saved article.

Sebastian
This was fixed in mozilla/kuma#4186.
Assignee: nobody → shobson
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Yes, saw it and works fine for me! Thanks a lot, Stephanie! That issue was really bugging me.

Sebastian
Status: RESOLVED → VERIFIED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.