silence spammy warnings from clang-cl when compiling icu

RESOLVED FIXED in Firefox 51

Status

RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

Trunk
mozilla51
All
Windows

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We get two warnings for ever ICU source file we compile:

- ICU defines WIN32_LEAN_AND_MEAN, which we do as well (in mozilla-config.h), so we get warnings about redefined macros;
- We get warnings from clang-cl about "Microsoft include rules", which AFAICT are more or less the include rules everybody expects

We should just turn these off.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8785422 [details]
Bug 1298466 - avoid some spammy warnings for ICU when compiling with clang-cl; .mielczarek

https://reviewboard.mozilla.org/r/74626/#review72928
Attachment #8785422 - Flags: review?(ted) → review+

Comment 3

2 years ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f33f496ab60c
avoid some spammy warnings for ICU when compiling with clang-cl; r=ted.mielczarek

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f33f496ab60c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

11 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.