|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
We get two warnings for ever ICU source file we compile: - ICU defines WIN32_LEAN_AND_MEAN, which we do as well (in mozilla-config.h), so we get warnings about redefined macros; - We get warnings from clang-cl about "Microsoft include rules", which AFAICT are more or less the include rules everybody expects We should just turn these off.
Comment on attachment 8785422 [details] Bug 1298466 - avoid some spammy warnings for ICU when compiling with clang-cl; .mielczarek https://reviewboard.mozilla.org/r/74626/#review72928
Attachment #8785422 - Flags: review?(ted) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f33f496ab60c avoid some spammy warnings for ICU when compiling with clang-cl; r=ted.mielczarek
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.