Closed
Bug 1298466
Opened 9 years ago
Closed 9 years ago
silence spammy warnings from clang-cl when compiling icu
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
We get two warnings for ever ICU source file we compile:
- ICU defines WIN32_LEAN_AND_MEAN, which we do as well (in mozilla-config.h), so we get warnings about redefined macros;
- We get warnings from clang-cl about "Microsoft include rules", which AFAICT are more or less the include rules everybody expects
We should just turn these off.
Comment hidden (mozreview-request) |
Comment 2•9 years ago
|
||
mozreview-review |
Comment on attachment 8785422 [details]
Bug 1298466 - avoid some spammy warnings for ICU when compiling with clang-cl; .mielczarek
https://reviewboard.mozilla.org/r/74626/#review72928
Attachment #8785422 -
Flags: review?(ted) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f33f496ab60c
avoid some spammy warnings for ICU when compiling with clang-cl; r=ted.mielczarek
Comment 4•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•