1298466 - silence spammy warnings from clang-cl when compiling icu

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

We get two warnings for ever ICU source file we compile:

- ICU defines WIN32_LEAN_AND_MEAN, which we do as well (in mozilla-config.h), so we get warnings about redefined macros;
- We get warnings from clang-cl about "Microsoft include rules", which AFAICT are more or less the include rules everybody expects

We should just turn these off.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1298466 - avoid some spammy warnings for ICU when compiling with clang-cl; .mielczarek

We don't need to hear about ICU redefining macros we set up or about
include paths that are Microsoft-specific, but still resolve to where
they need to go.

Review commit: https://reviewboard.mozilla.org/r/74626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74626/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8785422 [details]
Bug 1298466 - avoid some spammy warnings for ICU when compiling with clang-cl; .mielczarek

https://reviewboard.mozilla.org/r/74626/#review72928

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f33f496ab60c
avoid some spammy warnings for ICU when compiling with clang-cl; r=ted.mielczarek

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f33f496ab60c