1298491 - Null Pointer Derefernce in PLDHashTable::Search | PREF_CopyCharPref

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Adam Roach [:abr]]

This bug was filed from the Socorro interface and is 
report bp-bbe92e00-2234-4ac9-b0c7-91fee2160826.
=============================================================

When this happened to me, it happened repeatedly upon startup. I was forced to restore my profile from a recent backup to get Thunderbird back into a usable state.

Comment 1

[Adam Roach [:abr]]

See also --
https://crash-stats.mozilla.com/report/index/36667e9f-6dcf-4593-b392-558d52160826
https://crash-stats.mozilla.com/report/index/a47a386a-c7d9-41ba-a1d8-ed4902160826
https://crash-stats.mozilla.com/report/index/8087b873-0c5c-4b8a-abdb-e4b972160826

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Adam Roach [:abr] from comment #0)
> This bug was filed from the Socorro interface and is 
> report bp-bbe92e00-2234-4ac9-b0c7-91fee2160826.
> =============================================================
> 
> When this happened to me, it happened repeatedly upon startup. I was forced
> to restore my profile from a recent backup to get Thunderbird back into a
> usable state.

Mac signature, all the reports are yours except a couple https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=PLDHashTable%3A%3ASearch%20%7C%20PREF_CopyCharPref&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=uptime&_sort=-date&page=1

A bad folder maybe? Anything unusual seen in the day or two before crashes started?
(unclear whether related to bug 1276488)

0	XUL	PLDHashTable::Search(void const*)	xpcom/glue/PLDHashTable.cpp:531
1	XUL	PREF_CopyCharPref	modules/libpref/prefapi.cpp:701
2	XUL	nsMsgIncomingServer::GetCharValue(char const*, nsACString_internal&)	/builds/slave/tb-rel-c-esr45-m64_bld-0000000/build/mailnews/base/util/nsMsgIncomingServer.cpp:508
3	XUL	NS_InvokeByIndex	xpcom/reflect/xptcall/md/unix/xptcinvoke_x86_64_unix.cpp:174
4	XUL	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)	js/xpconnect/src/XPCWrappedNative.cpp:2097
5	XUL	XPC_WN_GetterSetter(JSContext*, unsigned int, JS::Value*)	js/xpconnect/src/xpcprivate.h:2152
6	XUL	js::jit::DoCallNativeGetter(JSContext*, JS::Handle<JSFunction*>, JS::Handle<JSObject*>, JS::MutableHandle<JS::Value>)	js/src/jit/SharedIC.cpp:3668
7		@0x108ea0ca7	
8		@0x1244f541f	
9		@0x108e9c84e	
10	XUL	EnterBaseline	js/src/jit/BaselineJIT.cpp:145
11	XUL	js::jit::EnterBaselineMethod(JSContext*, js::RunState&)	js/src/jit/BaselineJIT.cpp:184
12	XUL	Interpret	js/src/vm/Interpreter.cpp:2811
13	XUL	js::RunScript(JSContext*, js::RunState&)	js/src/vm/Interpreter.cpp:391
14	XUL	js::Invoke(JSContext*, JS::CallArgs const&, js::MaybeConstruct)	js/src/vm/Interpreter.cpp:462
15	XUL	js::Invoke(JSContext*, JS::Value const&, JS::Value const&, unsigned int, JS::Value const*, JS::MutableHandle<JS::Value>)	js/src/vm/Interpreter.cpp:496
16	XUL	js::jit::DoCallFallback	js/src/jit/BaselineIC.cpp:6162
17		@0x108e9fd2f	
18		@0x122e2928f	
19		@0x108e9c84e	
20	XUL	EnterBaseline	js/src/jit/BaselineJIT.cpp:145
21	XUL	js::jit::EnterBaselineMethod(JSContext*, js::RunState&)	js/src/jit/BaselineJIT.cpp:184
22	XUL	js::RunScript(JSContext*, js::RunState&)	js/src/vm/Interpreter.cpp:381

Comment 3

[Adam Roach [:abr]]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #2)
> Mac signature, all the reports are yours except a couple
...
> A bad folder maybe? Anything unusual seen in the day or two before crashes
> started?

If it's just me, probably not worth burning cycles on the root cause, but a null-check band-aid would be quick and easy. I do get periodic crashes -- about one every two weeks on average -- and poking through the ones over the past several months, they appear to all have the same null deref (although not necessarily the same stack; cf. https://crash-stats.mozilla.com/report/index/87016ca2-5c41-40f1-bbf2-343542160502). Aside from these, nothing stands out about the past week or so.

Comment 4

[Phil Pishioneri]

I just had one of these a couple of days ago on my Mac

bp-39682019-d303-4966-822b-6df1d2170327

can't recall any others, and the subsequent start was uneventful (no repeating crashes).

Comment 5

[Wayne Mery (:wsmwk)]

still seeing this?

Comment 6

[Adam Roach [:abr]]

(In reply to Wayne Mery (:wsmwk) from comment #5)

still seeing this?

I did a glance through the past few months of my crash reports, and I don't see anything pref-related at all. If Phil hasn't seen it either, you can probably close this bug.

Comment 7

[Wayne Mery (:wsmwk)]

THanks Adam