Closed Bug 1298530 Opened 7 years ago Closed 7 years ago

Strikethrough on blocked permissions was removed from control center

Categories

(Firefox :: Site Identity, defect, P1)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 51
Iteration:
51.3 - Sep 19
Tracking Flags:
Tracking Status
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- verified

People

(Reporter: MattN, Assigned: johannh)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [fxprivacy] )

Attachments

(1 file)

Bug 1298530 - Fix strikethrough for blocked controlcenter permission icons.
58 bytes, text/x-review-board-request
florian
: review+
Details 
Perhaps this was intentional but something between Aug 24, 2016, 06:05 and Aug 25, 2016, 17:13 nightlies removed the strikethrough in the control center panel for blocked permissions.

I'm guessing it was bug 1297405.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Iteration: --- → 51.3 - Sep 12
Flags: qe-verify?
Comment on attachment 8786363 [details]
Bug 1298530 - Fix strikethrough for blocked controlcenter permission icons.

https://reviewboard.mozilla.org/r/75332/#review73580
Attachment #8786363 - Flags: review?(florian) → review+
Flags: qe-verify? → qe-verify+
https://hg.mozilla.org/integration/fx-team/rev/212b8ad12f3cc173e4f9b03d8e38909fd31277b9
Bug 1298530 - Fix strikethrough for blocked controlcenter permission icons. r=florian
https://hg.mozilla.org/mozilla-central/rev/212b8ad12f3c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
QA Contact: paul.silaghi
Verified fixed FX 51.0a1 (2016-09-05) Win 7, Ubuntu 14.04, OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox51: fixed → verified
Is it expected not to have the strikethrough over the "Open pop-up windows" and "Install add-ons" permissions?
Flags: needinfo?(jhofmann)
Yes, that's expected. It's mostly that these icons aren't in the SVG file with the strikethroughs. Not sure if it's worth filing a follow-up.
Flags: needinfo?(jhofmann)
Depends on: 1302307
You need to log in before you can comment on or make changes to this bug.