Move --with-linux-headers to Python configure

RESOLVED FIXED in Firefox 51

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8785492 [details]
Bug 1298536 - Allow flags passed to try_compile to be a depends function.

https://reviewboard.mozilla.org/r/74662/#review73448
Attachment #8785492 - Flags: review?(mh+mozilla) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8785493 [details]
Bug 1298536 - Move --with-linux-headers to Python configure.

https://reviewboard.mozilla.org/r/74664/#review73450

::: build/moz.configure/headers.configure:65
(Diff revision 1)
>      'netinet/in.h',
>      'byteswap.h',
>      when=non_msvc_compiler,
>  )
> +
> +have_perf_event_h = check_header('linux/perf_event.h',

Can you add a TODO that this needs to move in a --enable-project=js specific file?
Attachment #8785493 - Flags: review?(mh+mozilla) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4df9ee747c3
Allow flags passed to try_compile to be a depends function. r=glandium
https://hg.mozilla.org/integration/autoland/rev/3f398fa60de0
Move --with-linux-headers to Python configure. r=glandium

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a4df9ee747c3
https://hg.mozilla.org/mozilla-central/rev/3f398fa60de0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.