Closed Bug 1298554 Opened 3 years ago Closed 3 years ago

[Test] Remove the some animation.id tests from mochitest.

Categories

(Core :: DOM: Animation, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

Details

Attachments

(1 file, 1 obsolete file)

Currently we have the mochitest of animation.id.(dom/animation/test/css-animatoins/file_animation-id.html)[1] 
But there is same test in w-p-f test. (testing/web-platform/tests/web-animations/interface/Animaiton/id.html)[2] 

So we can remove this tests from the mochitest.

[1] http://searchfox.org/mozilla-central/rev/f80822840bc5f3d2d3cae3ece621ddbce72e7f54/dom/animation/test/css-animations/file_animation-id.html
[2] https://dxr.mozilla.org/mozilla-central/rev/a551f534773cf2d6933f78ce7d82a7a33a99643e/dom/animation/test/css-animations/file_animation-id.html#21
Assignee: nobody → mantaroh
Comment on attachment 8785520 [details]
Bug 1298554 - Remove the animation.id mochitest.

https://reviewboard.mozilla.org/r/74688/#review72540

Looks good. Can you fix testing/web-platform/tests/web-animations/interfaces/Animation/id.html too? The messages refer to CSS Animations but the test is not about CSS Animations.

We also need to test that the ID passed to element.animate() / Animation constructor is correctly reflected but perhaps we have tests for them.
Attachment #8785520 - Flags: review?(bbirtles) → review+
Priority: -- → P5
Attachment #8785520 - Attachment is obsolete: true
Comment on attachment 8789242 [details]
Bug 1298554 - Remove the animation.id mochitest.

https://reviewboard.mozilla.org/r/77520/#review76100

::: testing/web-platform/tests/web-animations/interfaces/Animation/id.html:17
(Diff revision 1)
>  "use strict";
>  
>  test(function(t) {
>    var div = createDiv(t);
>    var animation = div.animate({}, 100 * MS_PER_SEC);
> -  assert_equals(animation.id, '', 'id for CSS Animation is initially empty');
> +  assert_equals(animation.id, '', 'id for Web Animations is initially empty');

This should just be 'id for Animation is initially empty'

::: testing/web-platform/tests/web-animations/interfaces/Animation/id.html:21
(Diff revision 1)
>    var animation = div.animate({}, 100 * MS_PER_SEC);
> -  assert_equals(animation.id, '', 'id for CSS Animation is initially empty');
> +  assert_equals(animation.id, '', 'id for Web Animations is initially empty');
>    animation.id = 'anim'
>  
>    assert_equals(animation.id, 'anim', 'animation.id reflects the value set');
> -}, 'Animation.id for CSS Animations');
> +}, 'Animation.id for Web Animations API');

This should just be 'Animation.id initial value and setter'

(We really should split this into two tests: one for testing the initial value, one for testing the setter)
Attachment #8789242 - Flags: review?(bbirtles) → review+
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/de68ac5bf9e4
Remove the animation.id mochitest. r=birtles
https://hg.mozilla.org/mozilla-central/rev/de68ac5bf9e4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.