Closed Bug 1298562 Opened 5 years ago Closed 5 years ago

Some values in Cocoa's TextInputHandler log isn't outputted as 0 when it is 0

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: m_kato, Unassigned)

Details

(Keywords: inputmethod)

Attachments

(1 file)

When debugging cocoa's IM, I found that some output log is incorrect (although value is 0, log is outputted as 0x7fff00000000).

mReply.mOffset and nsAString.Length() is uint32_t, but we use it as long long unsigned.
Keywords: inputmethod
- InputHandler::GetAttributedSubstringFromRange
  - mReply.mOffset 
- IMEInputHandler::SelectedRange
  - mReply.mOffset
  - mString.Length()
Comment on attachment 8785564 [details]
Bug 1298562 - Use %u instead of %llu for uint32_t.

https://reviewboard.mozilla.org/r/74734/#review73424
Attachment #8785564 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/de41b9a9ba4f
Use %u instead of %llu for uint32_t. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/de41b9a9ba4f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.