Closed Bug 1298569 Opened 3 years ago Closed 3 years ago

Add NEON_FLAGS for both arm and aarch64 like SSE2_FLAGS

Categories

(Firefox Build System :: General, defect)

Other
Unspecified
defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: m_kato, Unassigned)

Details

Attachments

(3 files)

Actually, we have SSE2_FLAG for x86 and x86_64.  Because it is for compatible of each CPU and compilers.  (x86_64 uses -msse2 as default, but x86 doesn't use -msse2 as default).

For moz.build, we should add neon flag too.  arm32 requires neon flags, but aarch64 doesn't.
Summary: Add NEON_FLAG for both arm and aarch64 like SSE2_FLAG → Add NEON_FLAGS for both arm and aarch64 like SSE2_FLAGS
Comment on attachment 8789318 [details]
Bug 1298569 - Part 1. Add NEON_FLAGS for arm32.

https://reviewboard.mozilla.org/r/77534/#review76880
Attachment #8789318 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8789319 [details]
Bug 1298569 - Part 2. Replace -fpu=neon with CONFIG['NEON_FLAGS'].

https://reviewboard.mozilla.org/r/77536/#review76878

::: gfx/skia/generate_mozbuild.py:437
(Diff revision 1)
>    f.write("elif CONFIG['CPU_ARCH'] == 'arm' and CONFIG['GNU_CC']:\n")
>    write_sources(f, sources['arm'], 4)
>  
>    f.write("    if CONFIG['BUILD_ARM_NEON']:\n")
>    write_list(f, 'SOURCES', sources['neon'], 8)
> -  write_cflags(f, sources['neon'], 'neon', '-mfpu=neon', 8)
> +  write_cflags(f, sources['neon'], 'neon', "CONFIG[\'NEON_FLAGS\']", 8)

Those backslashes shouldn't be necessary.
Attachment #8789319 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8789320 [details]
Bug 1298569 - Part 3. Remove unused MOZ_ARM_VFP_FLAGS flag.

https://reviewboard.mozilla.org/r/77538/#review76882
Attachment #8789320 - Flags: review?(mh+mozilla) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3356000cec59
Part 1. Add NEON_FLAGS for arm32. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ae9a8843ec
Part 2. Replace -fpu=neon with CONFIG['NEON_FLAGS']. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e355b663626
Part 3. Remove unused MOZ_ARM_VFP_FLAGS flag. r=glandium
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.