Closed Bug 1298586 Opened 3 years ago Closed 3 years ago

Intermittent dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html | sink is 1/2 width of source - got 50, expected 25

Categories

(Core :: WebRTC, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bwc)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Rank: 35
Priority: -- → P3
This is looking pretty frequent. Started shortly after bug 1275461 landed, so that's probably a good starting point :)
Flags: needinfo?(docfaraday)
Looks like the first checking in bug 1275461 on 8-10 brought down the rate quite a bit. But it's a little early to judge how much the second checking on 8-26 changed things:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275461&tree=trunk&startday=2016-08-01&endday=2016-08-27
While bug 1275461 happened across all OS's this new bug appears to happen on Linux and Android only. Yeah according to orange factor this started right after the checking on 8-26.
Assignee: nobody → docfaraday
Flags: needinfo?(docfaraday)
Comment on attachment 8789871 [details]
Bug 1298586: Wait for an additional frame.

https://reviewboard.mozilla.org/r/77924/#review76442

LGTM

::: dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html:106
(Diff revision 1)
>            ok(vremote, "Should have remote video element for pcRemote");
>            return helper.waitForFrames(vremote);
>          },
> +        // For some reason, even though we're getting a 25x25 stream, sometimes
> +        // the resolution isn't updated on the video element on the first frame.
> +        function PC_REMOTE_WAIT_FOR_FRAMES_3() {

I would have never expected that the solution is to add more checks.
Attachment #8789871 - Flags: review?(drno) → review+
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/082c1bcd6035
Wait for an additional frame. r=drno
https://hg.mozilla.org/mozilla-central/rev/082c1bcd6035
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.