Closed Bug 1298593 Opened 8 years ago Closed 4 years ago

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/folder-display/test-displaying-messages-in-folder-tabs.js

Categories

(Thunderbird :: Testing Infrastructure, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: jorgk-bmo, Assigned: aceman)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/folder-display/test-displaying-messages-in-folder-tabs.js | test-displaying-messages-in-folder-tabs.js::test_display_message_with_no_3pane_windows_open

First seen Fri Aug 26, 2016, 23:54:36 on Linux 64 debug
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=45dba2f8a9f9b9cf7e833024a9c1f30f1b4c38a5&selectedJob=44853

INFO -  SUMMARY-UNEXPECTED-FAIL | test-displaying-messages-in-folder-tabs.js | test-displaying-messages-in-folder-tabs.js::test_display_message_with_no_3pane_windows_open
INFO -    EXCEPTION: There should be 1 tabs open, but there are actually 3 tabs open. Tabs: [undefined undefined]
INFO -      at: test-folder-display-helpers.js line 107
INFO -         setupModule/testHelperModule.do_throw test-folder-display-helpers.js:107 13
INFO -         mark_failure logHelper.js:645 3
INFO -         assert_number_of_tabs_open test-folder-display-helpers.js:762 5
INFO -         test_display_message_with_no_3pane_windows_open test-displaying-messages-in-folder-tabs.js:91 3
INFO -         Runner.prototype.wrapper frame.js:585 9
INFO -         Runner.prototype._runTestModule frame.js:655 9
INFO -         Runner.prototype.runTestModule frame.js:701 3
INFO -         Runner.prototype.runTestDirectory frame.js:525 7
INFO -         runTestDirectory frame.js:707 3
INFO -         Bridge.prototype._execFunction server.js:179 10
INFO -         Bridge.prototype.execFunction server.js:183 16
INFO -         Session.prototype.receive server.js:283 3
INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3
I'm on the right platform here, but I can't see it locally yet. But I can look into it.
Attached patch patchSplinter Review
This patch seems to help on try server.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=47aa3ca6f6543a80283553898508582611d872f3
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=873db832f6a5be187186a0ace745bbfa5708913a
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e5184e7984c75d03e2b862c589d2c902cae96826

The run is not completely green, due to some python problem. But inspecting the log shows this particular failure in test-*-in-folder-tabs.js is gone.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #8802391 - Flags: review?(mkmelin+mozilla)
Attachment #8802391 - Flags: review?(jorgk)
Component: General → Testing Infrastructure
Version: unspecified → Trunk
Comment on attachment 8802391 [details] [diff] [review]
patch

> The run is not completely green, due to some python problem. But inspecting
> the log shows this particular failure in test-*-in-folder-tabs.js is gone.
If this is so ... ;-)
r+
Surely the mc.waitFor(() => ... doesn't do any damage.
Attachment #8802391 - Flags: review?(jorgk) → review+
Right when we want to land it, the last try run still has the failure even with the patch :(
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=300bc0e3e759bb488d9021548cf535c5fa4f9dd0

Only that there are only 2 tabs instead of 3 now ;)
Attachment #8802391 - Flags: review?(mkmelin+mozilla) → review+
Thanks for the reviews, but I now think the patch actually does not work yet.
Jorg, can you run the test mozmill\message-window\test-autohide-menubar.js  on Windows and see if it fails locally with this patch? It seems pretty consistent on try. Can you see in wha state it ends up? What windows stay open and which one is focused?
Flags: needinfo?(jorgk)
mozmake SOLO_TEST=message-window/test-autohide-menubar.js mozmill-one
works for me locally with and without the patch.

What else do you want me to do?
Flags: needinfo?(jorgk)
Thanks, maybe run the whole folder as the normal test run does.
How do I do that? Also, you want me to sit and watch or can I walk away from the screen? But then I won't see the state of the windows when the test fails.
make SOLO_TEST=message-window mozmill-one

I think you need to watch it to see how that particular test finishes.
I ran
  mozmake SOLO_TEST=message-window mozmill-one
twice with the patch without watching. 18 tests passed.

mozmill is gone

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: