12986 - [PP]Patching binary file fails resulting in zero k file

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 8/31/99 SeaMonkey build

1. From http://jimbob/trigger2.html, click drop-down button and select
   f_addmacpatch
2. Trigger this file to create a subdirectory,
   f_macpatch_exe:mac_patch_here:Note Pad under "Program"
3. Then select f_macpatch from drop-down list and trigger

vi.init("8.8.8.9");
Install.StartInstall("Functional: f_macpatch_exe", "/f_macpatch_exe", vi, 0);
f = Install.GetFolder("Program", "f_macpatch_exe/mac_patch_here");
err = Install.Patch(regName, vi, jarSrc, f, "Note Pad", true);
Install.LogComment("Install Patch = " + err);

RESULT:
The Version Registry updates with the patch.  The Install.log shows that the
patching is successful.  But checking the file shows that it has zero K size.
Also, it no longer possess application Kind, and instead has document Kind.  The
file does not have a resource fork.

EXPECTED RESULT:
The file keeps the name, Note Pad, but launching it reveals that it is now
Simple Text.

NOTE:
Because the Version Registry actually was updated, we need to consider how we
are validating a successful patch.  Obviously, it's not good if we did not
expect the Version Registry to be updated.

Comment 1

[Cathleen]

binary file patch seems to work (i.e. not generating zero k file), but something
is missing. Possibly, resource fork is screwed, because it never made into the
applesingle scrambling code, so it would be handled correctly.

Comment 2

[Cathleen]

it's fixed, with dougt's help!  :-)
will be in tomorrow's build.

Comment 3

[Jimmy Lee]

Build 9/29/99

Looks good.

Comment 4

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine