1298655 - Add bindings for constructing nsCSSShadowArray

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Manish Goregaokar [:manishearth]]

Needed for text-shadow and box-shadow.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1298655 - Add bindings for constructing nsCSSShadowArray;

Review commit: https://reviewboard.mozilla.org/r/74786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74786/

Comment 2

[Manish Goregaokar [:manishearth]]

While bug 1298634 will change some of how nsCSSShadowArray works, we'll still need these functions.

Comment 3

[Manish Goregaokar [:manishearth]]

Servo PR at https://github.com/servo/servo/pull/13086

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8785644 [details]
Bug 1298655 - Add bindings for constructing nsCSSShadowArray;

https://reviewboard.mozilla.org/r/74786/#review72906

::: layout/style/ServoBindings.h:267
(Diff revision 1)
>  mozilla::StyleBasicShape* Gecko_NewBasicShape(mozilla::StyleBasicShapeType type);
>  
>  void Gecko_FillAllBackgroundLists(nsStyleImageLayers* layers, uint32_t max_len);
>  NS_DECL_THREADSAFE_FFI_REFCOUNTING(nsStyleCoord::Calc, Calc);
>  
> +nsCSSShadowArray* Gecko_Construct_CSSShadowArray(uint32_t len);

It seems like the naming should be made consistent with Gecko_NewBasicShape rather than the style struct routines (since the latter are in-place). So I'd say Gecko_NewCSSShadowArray.

Also, we should adopt Xidorn's new convention (Servo_ObjectType_Operation) for the Gecko_ methods as well. Can you file a bug for that?

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8785644 [details]
Bug 1298655 - Add bindings for constructing nsCSSShadowArray;

https://reviewboard.mozilla.org/r/74786/#review72910

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8785644 [details]
Bug 1298655 - Add bindings for constructing nsCSSShadowArray;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74786/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/587acc47ecd1
Add bindings for constructing nsCSSShadowArray; r=bholley

Comment 8

[Manish Goregaokar [:manishearth]]

Filed bug 1299020

I'd prefer if we waited on that till the safety stuff lands; the rebases get horrible (especially when the order of arguments is swapped around).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/587acc47ecd1