1298668 - When rejecting references to multiple bugs, say which bugs were found

Status: RESOLVED INVALID

(MozReview Graveyard :: Integration: Git, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

On my first attempted push to MozReview, I was told:

  error: cannot submit reviews referencing multiple bugs
  hint: limit reviewed commits by specifying a commit or revrange as an argument

It was a 24-patch series, and I couldn't figure out what was wrong.  Eventually I hacked the script to output the bug numbers it had found, and it turns out I had transposed two digits in the middle of one of them.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8785679 [details] [diff] [review]
Patch

Review of attachment 8785679 [details] [diff] [review]:
-----------------------------------------------------------------

This needs a corresponding test update to git/tests/test-mozreview-commit-selection.t.

Also, why didn't you use MozReview to submit this review?

::: git/commands/git-mozreview
@@ +447,5 @@
>              ui.write('error: cannot submit reviews referencing multiple bugs\n')
>              ui.write('hint: limit reviewed commits by specifying a commit '
>                    'or revrange as an argument\n')
> +            ui.write('hint: detected bugs: ' +
> +                     ', '.join(identifiers).replace('bz://', '') + '\n')

Using % formatting is preferred over string concatenation. e.g.

'hint: detected bugs: %s\n' % ', '.join(...)

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Unfortunately, trying to get tests working locally was more effort than this patch is worth to me, so I won't try to fix it up.  :(

Comment 4

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.