Closed
Bug 1298731
Opened 8 years ago
Closed 8 years ago
Autophone - retry urlretrieve upon SSLError errors
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
829 bytes,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
I have run into instances where urlretrieve fails to download files such as tests or symbols due to errors which are not ContentTooShortErrors. From what I can tell urllib.urlretrieve can raise children of SSLErrors.
Assignee | ||
Comment 1•8 years ago
|
||
Unfortunately, I haven't seen this again. Perhaps a better choice would be to just retry on any error but I was reluctant to do that.
Attachment #8785768 -
Flags: review?(gbrown)
Updated•8 years ago
|
Attachment #8785768 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://github.com/mozilla/autophone/commit/b578c86dd013cfdb9276133c1d2b4d2572276017
Blocks: 1299842
Assignee | ||
Comment 3•8 years ago
|
||
deployed 2016-09-04 ~13:40 PDT
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•