Closed
Bug 1298734
Opened 8 years ago
Closed 8 years ago
Autophone - sensitive data filter should fall back to sensitive if it has exceptions
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
1006 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
I ran into a case over the weekend where the sensitive data filter threw a UnicodeDecodeError while inspecting the logging message. Rather than have the exception, I think it is better to treat the exception as sensitive and not display it.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8785771 -
Flags: review?(jmaher)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8785771 [details] [diff] [review] bug-1298734-v1.patch Review of attachment 8785771 [details] [diff] [review]: ----------------------------------------------------------------- good catch!
Attachment #8785771 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://github.com/mozilla/autophone/commit/63988310ca04723072c9bd0d1dede4a1371bcb52
Blocks: 1299842
|
|
Assignee | |
Comment 4•8 years ago
|
||
deployed 2016-09-04 ~13:40 PDT
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•