Closed Bug 1298889 Opened 7 years ago Closed 7 years ago

[RTL] "Firefox <VersionNumber>" is hidden by Firefox logo in about:firefox

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
Unspecified
Android
Type:
defect

Tracking

(firefox53 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox53 --- verified

People

(Reporter: itiel_yn8, Assigned: tomer)

References

(
URL
)

Details

(Keywords: rtl)

Attachments

(2 files)

Firefox text and logo hidden
274.95 KB, image/png
Details
Bug 1298889 [RTL] "Firefox \<VersionNumber\>" is hidden by Firefox logo in about:firefox
58 bytes, text/x-review-board-request
sebastian
: review+
Details 
      No description provided.
Summary: [RTL] "Firefox <VersionNumber>" is hidden by Firefox logo in about → [RTL] "Firefox <VersionNumber>" is hidden by Firefox logo in about:firefox
On RTL builds, when opening about:firefox, the "Firefox" brand name and the installed version are being hidden by the Firefox logo.
The Firefox logo should be aligned to the left side of the page, thus revealing the "Firefox" and the installed version.

Screenshot is attached.

    
    

    
  
Still an issue in latest Nightly builds.

    
  
Version: 48 Branch → unspecified

    
    

    
  
Since the content is always LTR, the block should be hardcoded to LTR. It is a one line change.
Assignee: nobody → tomer.moz.bugs
URL: https://dxr.mozilla.org/mozilla-centr...
Status: NEW → ASSIGNED

    
    

    
  
@Tomer
You should find a suitable reviewer for this, and ask him directly in the commit message with r?NICKNAME

    
  
See Also:  → 1298903

    
  

        Attachment #8817044 -
        Flags: review?(liuche)

    
  

        Attachment #8817044 -
        Flags: review?(liuche) → review?(s.kaspari)

    
    

    
  
Comment on attachment 8817044 [details]
Bug 1298889 [RTL] "Firefox \<VersionNumber\>" is hidden by Firefox logo in about:firefox

https://reviewboard.mozilla.org/r/97476/#review99956

        Attachment #8817044 -
        Flags: review?(s.kaspari) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/659010f84c9f
[RTL] "Firefox \<VersionNumber\>" is hidden by Firefox logo in about:firefox r=sebastian
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/659010f84c9f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox53:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

    
    

    
  
Working okay in latest Nightly build.

    
    

    
  
Tested on latest Nightly build 53.0a1 (2017-01-10) using next devices:
- Huawei Honor 5x (Android 5.1.1);
- Nexus 5 (Android 6.0.1).

The "Firefox" text and build version are now visible on the left side of the logo.

Based on these results and also on comment 10, I'm marking this bug as Verified.
Status: RESOLVED → VERIFIED

          status-firefox53:
          fixed → verified

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.