Remove (or document as non-functional) eRestarti386 and eRestartx86_64 constants

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Startup and Profile System
P3
normal
RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: spohl, Assigned: Josh Aas)

Tracking

({good-first-bug})

unspecified
mozilla57
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
With attachment 8783782 [details] [diff] [review] from bug 1250901 landing, we can remove (or document as non-functional) the eRestarti386 and eRestartx86_64 constants since they're no longer used.
(Reporter)

Comment 1

a year ago
We should also make sure that [1] gets updated appropriately.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIAppStartup

Updated

a year ago
Priority: -- → P3
(Assignee)

Updated

2 months ago
Assignee: nobody → jaas
(Assignee)

Comment 2

2 months ago
Created attachment 8902233 [details] [diff] [review]
fix v1.0
Attachment #8902233 - Flags: review?(spohl.mozilla.bugs)
(Reporter)

Comment 3

2 months ago
Comment on attachment 8902233 [details] [diff] [review]
fix v1.0

Review of attachment 8902233 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8902233 - Flags: review?(spohl.mozilla.bugs) → review+
(Reporter)

Comment 4

2 months ago
(In reply to Stephen A Pohl [:spohl] from comment #1)
> We should also make sure that [1] gets updated appropriately.
> 
> [1]
> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/
> Interface/nsIAppStartup

I went ahead and updated this doc.
(Assignee)

Comment 5

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60a3ecd41d439e188cb41c2b21e0b33a2caa7e79
(Assignee)

Updated

2 months ago
Keywords: checkin-needed

Comment 6

2 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5c10d36a74c
Remove the eRestarti386 and eRestartx86_64 constants. r=spohl
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5c10d36a74c
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.